- Notifications
You must be signed in to change notification settings - Fork919
feat(cssModules): namedExport support#1909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
b271eb9
to7c3fd0e
Compare7c3fd0e
tod3ca9f8
Compare3cdd2be
to30d2938
Compare30d2938
to855ca04
Compare855ca04
to98c07b1
Compare98c07b1
to34f4ecf
Compare34f4ecf
to40c92bd
Compare40c92bd
to3a61ba2
CompareFor v17Support css-loader : `options.modules.namedexport`https://github.com/webpack-contrib/css-loader/tree/v4.3.0#namedexporthttps://github.com/webpack-contrib/css-loader#namedexportfeat(cssModules ): namedExport support
3a61ba2
toa6b387b
CompareKocal commentedSep 20, 2024
Hi everyone, I'm very interested by this PR for letting us upgrade css-loader from v6 to v7 in webpack Encore, seesymfony/webpack-encore#1319 What is the state of this PR, is there anything else to do before reviewing/merging/releasing? |
To be honest, I don't fully understand all the codes of Since the release of If anyone would like to push forward with the merging of this feature, or help improve the reliability of the code, I would be very grateful. |
Kocal commentedSep 22, 2024
Thanks for your work!
Yeah I understand, that's what I am afraid of too when I see no releases for ~10 months :/ FYI In Encore context, I think we will take the decision to force the user to configure |
Uh oh!
There was an error while loading.Please reload this page.
For v17
Support css-loader :
options.modules.namedexport
https://github.com/webpack-contrib/css-loader/tree/v4.3.0#namedexport
https://github.com/webpack-contrib/css-loader#namedexport
Fix:#1788,#1794,#1709,#1612,#1866