Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat(cssModules): namedExport support#1909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Airkro wants to merge1 commit intovuejs:main
base:main
Choose a base branch
Loading
frombest-shot:feat/css-modules-named-export

Conversation

Airkro
Copy link

@AirkroAirkro commentedDec 16, 2021
edited
Loading

@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch fromb271eb9 to7c3fd0eCompareMay 9, 2023 08:19
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from7c3fd0e tod3ca9f8CompareMay 17, 2023 02:06
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch 2 times, most recently from3cdd2be to30d2938CompareMay 30, 2023 04:05
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from30d2938 to855ca04CompareJune 27, 2023 01:56
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from855ca04 to98c07b1CompareOctober 17, 2023 02:12
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from98c07b1 to34f4ecfCompareNovember 1, 2023 03:42
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from34f4ecf to40c92bdCompareJanuary 2, 2024 03:16
@AirkroAirkro changed the titlefeat(cssModules ): namedExport supportfeat(cssModules): namedExport supportApr 25, 2024
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from40c92bd to3a61ba2CompareApril 25, 2024 01:26
@AirkroAirkroforce-pushed thefeat/css-modules-named-export branch from3a61ba2 toa6b387bCompareJuly 15, 2024 03:27
@Kocal
Copy link

Hi everyone, I'm very interested by this PR for letting us upgrade css-loader from v6 to v7 in webpack Encore, seesymfony/webpack-encore#1319

What is the state of this PR, is there anything else to do before reviewing/merging/releasing?
Thanks! 🙏🏻

@Airkro
Copy link
Author

To be honest, I don't fully understand all the codes ofvue-loader, but this PR can pass basic tests, has been released as@best-shot/vue-loader, and has supported multiple projects of the company I work for for many years. It is practically usable.

Since the release ofvite, the official has only provided basicvue-loader support for many years, refusing to add any additional features and fixes. Given the officialVue's neglect of thewebpack ecosystem, I have almost given up the possibility of it being merged.

If anyone would like to push forward with the merging of this feature, or help improve the reliability of the code, I would be very grateful.

@Kocal
Copy link

To be honest, I don't fully understand all the codes ofvue-loader, but this PR can pass basic tests, has been released as@best-shot/vue-loader, and has supported multiple projects of the company I work for for many years. It is practically usable.

Thanks for your work!
However, for a package such asSymfony Webpack Encore, I am not fan of replacing the officialvue-loader by an external (or even internal) fork, that would condemn the project more quickly. Also, I don't know the position of Symfony about forks, but I think it would be very similar.

Since the release ofvite, the official has only provided basicvue-loader support for many years, refusing to add any additional features and fixes. Given the officialVue's neglect of thewebpack ecosystem, I have almost given up the possibility of it being merged.

Yeah I understand, that's what I am afraid of too when I see no releases for ~10 months :/

FYI In Encore context, I think we will take the decision to force the user to configurecss-loader to not use named export if they use Vue.js + CSS Modules, since React/Preact + CSS modules users are not stuck because this kind of issue.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS modules documentation uses invalidcss-loader options object
2 participants
@Airkro@Kocal

[8]ページ先頭

©2009-2025 Movatter.jp