Commitaa2558d

committed

fix: don't prettify if prettier 3 is detected

1 parented0d284 commitaa2558dCopy full SHA for aa2558d

File tree

+17

-3

lines changed

+17

-3

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ When both options are specified, enables file-system-based template compilation`
`90`	`90`	`##prettify`
`91`	`91`
`92`	`92`	- type:`boolean`
`93`		-- default:`true`
	`93`	+- default:`true` if prettier v1 or v2 is installed,`false` otherwise
`94`	`94`
`95`	`95`	`In development mode, we use[prettier](https://prettier.io/) to format the compiled render function for ease of debugging by default. However, if you encounter any obscure bug of prettier, such as[exponential compilation time for deeply nested functions](https://github.com/prettier/prettier/issues/4672), you can disable this option to circumvent it.`
`96`	`96`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ sidebar: auto`
`90`	`90`	`##prettify`
`91`	`91`
`92`	`92`	- 类型：`boolean`
`93`		-- 默认值：`true`
	`93`	+- 默认值：当检测到 prettier v1 或 v2 时为`true`，否则为`false`
`94`	`94`
`95`	`95`	`在开发环境下，我们默认使用[prettier](https://prettier.io/) 格式化编译后的模板渲染代码，以方便调试。然而，如果你开发时碰到了 prettier 的某些罕见 bug，比如[格式化多层嵌套的函数时运行时间过长](https://github.com/prettier/prettier/issues/4672)，你可以通过禁用这个选项来绕开。`
`96`	`96`

Lines changed: 12 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -41,6 +41,17 @@ module.exports = function (source) {`
`41`	`41`	`constdescriptor=getDescriptor(filename,options,loaderContext)`
`42`	`42`	`constscript=resolveScript(descriptor,id,options,loaderContext)`
`43`	`43`
	`44`	`+// Prettier 3 APIs are all async`
	`45`	+// but `vue/compiler-sfc` and `@vue/component-compiler-utils` can only use sync function to format code
	`46`	`+lethasCompatiblePrettier=false`
	`47`	`+try{`
	`48`	`+constprettier=require('prettier/package.json')`
	`49`	`+constmajor=parseInt(prettier.version.split('.')[0],10)`
	`50`	`+if(major===1\|\|major===2){`
	`51`	`+hasCompatiblePrettier=true`
	`52`	`+}`
	`53`	`+}catch(e){}`
	`54`	`+`
`44`	`55`	`// for vue/compiler-sfc OR @vue/component-compiler-utils`
`45`	`56`	`constfinalOptions={`
`46`	`57`	`source,`
`@@ -53,7 +64,7 @@ module.exports = function (source) {`
`53`	`64`	`isProduction,`
`54`	`65`	`isFunctional,`
`55`	`66`	`optimizeSSR:isServer&&options.optimizeSSR!==false,`
`56`		`-prettify:options.prettify,`
	`67`	`+prettify:options.prettify===undefined ?hasCompatiblePrettier :options.prettify,`
`57`	`68`	`bindings:script ?script.bindings :undefined`
`58`	`69`	`}`
`59`	`70`

Lines changed: 3 additions & 0 deletions

Comments

(0)