Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.8k
fix: add v-show style in ssr if style is binding to an array#7814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
web/server/directives/show just add style.display='none', no matter style is object or array; Ifstyle is an array, it will lost additional property while tranformed into object inshared/utils#toObject;fixvuejs#7813
yyx990803 pushed a commit that referenced this pull requestMar 13, 2018
This was referencedMar 14, 2018
f2009 pushed a commit to f2009/vue that referenced this pull requestJan 25, 2019
aJean pushed a commit to aJean/vue that referenced this pull requestAug 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web/server/directives/show just add style.display='none', no matter style is object or array; If
style is an array, it will lost additional property while tranformed into object by
shared/utils#toObject;
fix#7813
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch),not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding anew feature, the PR's description includes:
Other information: