Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.8k
[weex] Adjust the weex platform entry file to fit the new weex runtime#6620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Remove the `callFunctionNative` method and `compileBundle`, which is provided by modified V8. Inorder to maintain the consistency of the js engine, Weex also use JSC on Android. The legacy hackfor V8 engine should be removed.
Modules and components should be registered in weex runtime, not the specific framework. The`registerModules`, `registerComponents`, `weex.supports` and `weex.requireModule` api is moved toweex runtime, which is in the "apache/incubator-weex" repo.
65f9c19 to2639d70Compareztlevi pushed a commit to ztlevi/vue that referenced this pull requestFeb 14, 2018
…ex runtime (vuejs#6620)* trim trailing whitespace* revert(weex): remove the new Function hack for V8, as Weex uses JSC nowRemove the `callFunctionNative` method and `compileBundle`, which is provided by modified V8. Inorder to maintain the consistency of the js engine, Weex also use JSC on Android. The legacy hackfor V8 engine should be removed.* refactor(weex): move module and component apis to weex runtimeModules and components should be registered in weex runtime, not the specific framework. The`registerModules`, `registerComponents`, `weex.supports` and `weex.requireModule` api is moved toweex runtime, which is in the "apache/incubator-weex" repo.* test(weex): refactor the test cases to fit the new weex-js-runtime* fix(weex): use document instead of renderer to create Element
f2009 pushed a commit to f2009/vue that referenced this pull requestJan 25, 2019
…ex runtime (vuejs#6620)* trim trailing whitespace* revert(weex): remove the new Function hack for V8, as Weex uses JSC nowRemove the `callFunctionNative` method and `compileBundle`, which is provided by modified V8. Inorder to maintain the consistency of the js engine, Weex also use JSC on Android. The legacy hackfor V8 engine should be removed.* refactor(weex): move module and component apis to weex runtimeModules and components should be registered in weex runtime, not the specific framework. The`registerModules`, `registerComponents`, `weex.supports` and `weex.requireModule` api is moved toweex runtime, which is in the "apache/incubator-weex" repo.* test(weex): refactor the test cases to fit the new weex-js-runtime* fix(weex): use document instead of renderer to create Element
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
new Functionhack for V8Remove the
callFunctionNativemethod and thecompileBundleAPI which is provided by modified V8.In order to maintain the consistency of the js engine, Weex also uses JSC on Android. The legacy hack for V8 engine should be removed.
Move shared APIs to Weex runtime
Modules and components should be registered in weex runtime, not in each front-end frameworks. The
registerModules,registerComponents,weex.supportsandweex.requireModuleAPIs is moved toWeex runtime which is in thehttps://github.com/apache/incubator-weex .
Use
documentinstead ofrendererUsing
documentis more standard than usingrenderer. ThecreateElementAPI support to create customWeexElementnow.Test cases
Weex's test cases have also been adjusted to fit the new
weex-js-runtimearchitecture.