Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/vuePublic

perf(core): getType uses a cache for well known types.#13225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Glandos wants to merge1 commit intovuejs:main
base:main
Choose a base branch
Loading
fromGlandos:patch-1

Conversation

Glandos
Copy link

@GlandosGlandos commentedNov 18, 2024
edited
Loading

getType is called a lot, and it just run the same regexp over and over on the same base types. A cache increase its own efficiency by more than 80% for basic types. On a real world application with a lot of components, getType was profiled for 8% of call duration before this patch, and about 0.5% after.
The impact is more limited for smaller applications.

Same as#12123, but against current main branch.

I know this won't be merged, but I abuse test runners, so I validate my patch against latest Vue before usingyarn patch

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: performance improvement

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

See#12123 for more detail.

brenoepics and etu-deulla reacted with eyes emoji
getType is called a lot, and it just run the same regexp over and over on the same base types.A cache increase its own efficiency by more than 80% for basic types.On a real world application with a lot of components,getType was profiled for 8% of call duration before this patch,and about 0.5% after.The impact is more limited for smaller applications.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@Glandos

[8]ページ先頭

©2009-2025 Movatter.jp