Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/vuePublic

fix: convert emits to props, fix #13104#13105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
so1ve wants to merge2 commits intovuejs:mainfromso1ve:fix/emits-to-props

Conversation

so1ve
Copy link
Member

@so1veso1ve commentedOct 23, 2023
edited
Loading

What kind of change does this PR introduce? (check at least one)

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding anew feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Converts emits to props.

Other information:

@yyx990803
Copy link
Member

@so1ve I tested this locally and it doesn't seem to fix#13104 - is this something you still intend to work on? We might be able to get this in the final patch release before EOL.

@so1ve
Copy link
MemberAuthor

I'll take a look and add tests

@so1ve
Copy link
MemberAuthor

I need some help, I couldn't get emits fromextends andmixin work...

@so1veso1ve closed thisDec 6, 2023
@so1ve
Copy link
MemberAuthor

This fix is beyond my capabilities and I hope someone else can fix it.

@zcf0508
Copy link

@so1ve I tested this locally and it doesn't seem to fix#13104 - is this something you still intend to work on? We might be able to get this in the final patch release before EOL.

#13133

https://github.com/vuejs/vue/pull/13133/files#diff-d26123bca327fbaf4e0ce33d7085fcaf9f4a39be4f76a1d0c15e0843afb1af9fR153

Maybe this is the key line to resolve the error of#13104

@so1ve
Copy link
MemberAuthor

No, your implementation doesn't takeextends andmixin into account

@zcf0508
Copy link

zcf0508 commentedDec 18, 2023
edited
Loading

No, your implementation doesn't takeextends andmixin into account

Yes, you are right, I'm working on it. But now I have some questions. I see you add a test that you can getemit functions fromprops insetup function, but theprops does not expose those functions. It is a right type test?

image

imageimage

@so1ve
Copy link
MemberAuthor

Yes, because it can beundefined

@zcf0508
Copy link

Does it mean that If a component useprops.onFoo in runtime, the function will never work? Is theonFoo only used for type inference?

@so1ve
Copy link
MemberAuthor

Yes, seemed to be true

@zcf0508
Copy link

image

#13133

I think it works with extends and mixin now.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue 2.7 strictTemplates error
3 participants
@so1ve@yyx990803@zcf0508

[8]ページ先頭

©2009-2025 Movatter.jp