Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.8k
chore(compiler-sfc): specify prettier version (fix #13052)#13053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a1fc76e
toe51b52f
Comparee51b52f
toed5010e
Compareed5010e
to786acf9
CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
close:#13052
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
main
branch for v2.x (or to a previous version branch)fix #xxx[,#xxx]
, where "xxx" is the issue number)If adding anew feature, the PR's description includes:
Other information:
@vue/compiler-sfc
optionally uses Prettier and it is not compatible with Prettier v3.But
prettier
is not listed in thepackage.json
.It wasn't a problem with Prettier v2 because prettier isoptional dependency of
component-compiler-utils
. So Prettier is installed anyway and everything works.But if some project has
Prettier@3
, then@vue/compiler-sfc
uses project's prettier and fails.There was the same issue early incomponent-compiler-utils. See:
This PR specifies Prettier as an
optionalDependency
of@vue/compiler-sfc
. With specified dependency, it will useprettier@2
even if a project hasprettier@3
.P.S. I used the same versions as it was in the
component-compiler-utils
. It seems it has the same code.Alternative solution: make
@vue/compiler-sfc
compatible with bothPrettier@"1 || 2"
andPrettier@3
. The problem is that it will make the compile function async.