fix: toString utils should unref the`Ref<T>`#12888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

enpitsuLin wants to merge1 commit intovuejs:mainfromenpitsuLin:fix/12884/tostring-should-unref

Closed

fix: toString utils should unref the`Ref<T>`#12888

enpitsuLin wants to merge1 commit intovuejs:mainfromenpitsuLin:fix/12884/tostring-should-unref

Uh oh!

There was an error while loading.Please reload this page.

Conversation

Copy link

enpitsuLin commentedNov 30, 2022

fix#12884

What kind of change does this PR introduce? (check at least one)

Bugfix
Feature
Code style update
Refactor
Build-related changes
Other, please describe:

Does this PR introduce a breaking change? (check one)

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

It's submitted to themain branch for v2.x (or to a previous version branch)
When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)
All tests are passing:https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#development-setup
New/updated tests are included

If adding anew feature, the PR's description includes:

A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

fix: toString util should unref theRef<T>

2a81e39

fixvuejs#12884

Copy link

Author

enpitsuLin commentedNov 30, 2022

Vue3 has a replacer parameter inJSON.stringify that call intoDisplayString but as same purposetoString doesn't

I'm not sure if I need to add that parameter or just do unref forRef<T>

Copy link

LingRen commentedMar 27, 2023

don't depend v3, use type

yyx990803 closed this inae3e4b1

Dec 6, 2023

Copy link

Member

yyx990803 commentedDec 6, 2023

It should use replacer, otherwise it won't unwrap nested refs.
It should not depend onv3, as it causes a circular dependency and causes runtime errors in the built version of Vue.
Seeae3e4b1

Labels

None yet

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You can’t perform that action at this time.

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches