Commitf5ef882

committed

fix(style): always set new styles

1 parentd6468c4 commitf5ef882Copy full SHA for f5ef882

File tree

+17

-4

lines changed

+17

-4

lines changed

Lines changed: 2 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -91,10 +91,8 @@ function updateStyle(oldVnode: VNodeWithData, vnode: VNodeWithData) {`
`91`	`91`	`}`
`92`	`92`	`for(nameinnewStyle){`
`93`	`93`	`cur=newStyle[name]`
`94`		`-if(cur!==oldStyle[name]){`
`95`		`-// ie9 setting to null has no effect, must use empty string`
`96`		`-setProp(el,name,cur==null ?'' :cur)`
`97`		`-}`
	`94`	`+// ie9 setting to null has no effect, must use empty string`
	`95`	`+setProp(el,name,cur==null ?'' :cur)`
`98`	`96`	`}`
`99`	`97`	`}`
`100`	`98`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -36,4 +36,19 @@ describe('vdom style module', () => {`
`36`	`36`	`expect(elm.style.fontSize).toBe('')`
`37`	`37`	`expect(elm.style.display).toBe('block')`
`38`	`38`	`})`
	`39`	`+`
	`40`	`+it('border related style should update correctly',()=>{`
	`41`	`+constvnode1=newVNode('p',{`
	`42`	`+style:{border:'10px solid red','border-bottom':'10px solid blue'}`
	`43`	`+})`
	`44`	`+constvnode2=newVNode('p',{`
	`45`	`+style:{`
	`46`	`+'border-right':'10px solid red',`
	`47`	`+'border-bottom':'10px solid blue'`
	`48`	`+}`
	`49`	`+})`
	`50`	`+patch(null,vnode1)`
	`51`	`+constelm=patch(vnode1,vnode2)`
	`52`	`+expect(elm.style.borderBottom).toBe('10px solid blue')`
	`53`	`+})`
`39`	`54`	`})`

Comments

(0)