Commite0747f4

committed

fix(keep-alive): fix memory leak without breaking transition tests

1 parent2632249 commite0747f4Copy full SHA for e0747f4

File tree

-4

lines changed

-4

lines changed

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,15 @@ function matches(`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`functionpruneCache(`
`36`		`-keepAliveInstance:{cache:CacheEntryMap;keys:string[];_vnode:VNode},`
	`36`	`+keepAliveInstance:{`
	`37`	`+cache:CacheEntryMap`
	`38`	`+keys:string[]`
	`39`	`+_vnode:VNode`
	`40`	`+$vnode:VNode`
	`41`	`+},`
`37`	`42`	`filter:Function`
`38`	`43`	`){`
`39`		`-const{ cache, keys, _vnode}=keepAliveInstance`
	`44`	`+const{ cache, keys, _vnode, $vnode}=keepAliveInstance`
`40`	`45`	`for(constkeyincache){`
`41`	`46`	`constentry=cache[key]`
`42`	`47`	`if(entry){`
`@@ -46,6 +51,7 @@ function pruneCache(`
`46`	`51`	`}`
`47`	`52`	`}`
`48`	`53`	`}`
	`54`	`+$vnode.componentOptions!.children=undefined`
`49`	`55`	`}`
`50`	`56`
`51`	`57`	`functionpruneCacheEntry(`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,8 +62,6 @@ const componentVNodeHooks = {`
`62`	`62`	`vnode,// new parent vnode`
`63`	`63`	`options.children// new children`
`64`	`64`	`)`
`65`		`-// #12187 unset children reference after use to avoid memory leak`
`66`		`-options.children=undefined`
`67`	`65`	`},`
`68`	`66`
`69`	`67`	`insert(vnode:MountedComponentVNode){`

Comments

(0)