Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Test support for multiple versions of ESLint Stylistic#2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
waynzh merged 8 commits intomasterfromstylistic
Aug 1, 2025

Conversation

@FloEdelmann
Copy link
Member

@FloEdelmannFloEdelmann commentedJul 31, 2025•
edited
Loading

Follow-up to#2830 (comment).

@ST-DDT It would be great if you could have a look at this 🙂

ST-DDT reacted with eyes emoji
@changeset-bot
Copy link

changeset-botbot commentedJul 31, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:bdcd7f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
eslint-plugin-vueMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

This comment was marked as resolved.

@FloEdelmannFloEdelmann marked this pull request as ready for reviewJuly 31, 2025 11:58
Copy link
Contributor

@ST-DDTST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. I haven't tested this version in any projects though, to check whether this "breaks"/changes anything there.

eslint-plugin-vue supports quite a lot versions of stylistic. I probably would have dropped one or two of them...

Copy link
Member

@waynzhwaynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks you!

@waynzhwaynzh merged commitfd6fc41 intomasterAug 1, 2025
15 checks passed
@waynzhwaynzh deleted the stylistic branchAugust 1, 2025 07:29
@github-actionsgithub-actionsbot mentioned this pull requestAug 1, 2025
@FloEdelmann
Copy link
MemberAuthor

check whether this "breaks"/changes anything there

Since this introduces only anoptional dependency with nearly all versions allowed, I think it should be fine.

supports quite a lot versions of stylistic. I probably would have dropped one or two of them

Yeah, we should definitely do that in the future, but I didn't want to introduce a (potentially) breaking change in this small PR.

ST-DDT reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@waynzhwaynzhwaynzh approved these changes

@ota-meshiota-meshiAwaiting requested review from ota-meshi

+1 more reviewer

@ST-DDTST-DDTST-DDT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FloEdelmann@ST-DDT@waynzh
[8]ページ先頭
©2009-2025 Movatter.jp