This allows configuring the rule such that certain variables are allowed inv-html=. For instance, we would like to allowlist variables named “*Html” (as in the test), where the name already marks them as containing safe HTML that’s expected to be used withv-html=.

I tried to follow existing code style in here, but still, this is my first time contributing to any eslint plugin (I think), so let me know if anything needs to be changed or improved :) the option name mimics e.g.no-unused-vars but could of course be changed. (Also, I’m not completely sure if it’s correct that the option value seems to require slashes around it in order to not be interpreted as a literal string.)

Copy link

changeset-botbot commentedJul 29, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:18fc869

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-vue	Minor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

feat: Add ignorePattern to no-v-html

c98c01e

This allows configuring the rule such that certain variables are allowedin v-html=. For instance, we would like to allowlist variables named“*Html” (as in the test), where the name already marks them ascontaining safe HTML that’s expected to be used with v-html=.

lucaswerkmeister force-pushed theno-v-html-ignorePattern branch from522c93a toc98c01eCompare

July 29, 2025 15:26

Copy link

ContributorAuthor

lucaswerkmeister commentedJul 29, 2025

(Also, I’m not completely sure if it’s correct that the option value seems to require slashes around it in order to not be interpreted as a literal string.)

Huh, apparentlyvue/no-unused-vars just usesnew RegExp(ignorePattern, 'u') rather than thetoRegExp helper. (I found thetoRegExp helper in some other rule, don’t remember which one.)

wmfgerrit pushed a commit to wikimedia/mediawiki-extensions that referenced this pull request

Jul 29, 2025

Update git submodules

40e79c7

* Update Wikibase from branch 'master'  to 47afac06a696e77eac205da4c5df7ce3fdd07e87  - Disable vue/no-v-html rule in wbui2025 directory        The v-html directive is part of our expected workflow for reusing    server-rendered HTML (property links, snak values; see the upcoming ADR    of T399832). As such, this eslint rule is not currently useful for us.    If eslint adds the ignorePattern (or similar) option suggested in [1],    then we may later use it again (but note that this will require us to    upgrade to the latest version of eslint-plugin-vue first).        [1]:vuejs/eslint-plugin-vue#2857        Change-Id: I8926d09a67927dc36b0bd5cfdb3e5c6a7256842e

wmfgerrit pushed a commit to wikimedia/mediawiki-extensions-Wikibase that referenced this pull request

Jul 29, 2025

Disable vue/no-v-html rule in wbui2025 directory

47afac0

The v-html directive is part of our expected workflow for reusingserver-rendered HTML (property links, snak values; see the upcoming ADRofT399832). As such, this eslint rule is not currently useful for us.If eslint adds the ignorePattern (or similar) option suggested in [1],then we may later use it again (but note that this will require us toupgrade to the latest version of eslint-plugin-vue first).[1]:vuejs/eslint-plugin-vue#2857Change-Id: I8926d09a67927dc36b0bd5cfdb3e5c6a7256842e

FloEdelmann requested changes

Jul 29, 2025

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution! I have some suggestions / requested changes.

lib/rules/no-v-html.jsShow resolvedHide resolved

lib/rules/no-v-html.js OutdatedShow resolvedHide resolved

tests/lib/rules/no-v-html.js OutdatedShow resolvedHide resolved

lib/rules/no-v-html.js OutdatedShow resolvedHide resolved

lucaswerkmeisterand others added3 commits

July 29, 2025 19:29

Apply suggestions from code review

9dcfc74

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

npm run lint:fix

6c775ac

Add to docs

cd23ada

lucaswerkmeister commented

Jul 29, 2025

View reviewed changes

lib/rules/no-v-html.jsShow resolvedHide resolved

FloEdelmann requested changes

Jul 29, 2025

View reviewed changes

docs/rules/no-v-html.md OutdatedShow resolvedHide resolved

lib/rules/no-v-html.jsShow resolvedHide resolved

lib/rules/no-v-html.js OutdatedShow resolvedHide resolved

docs/rules/no-v-html.mdShow resolvedHide resolved

lucaswerkmeisterand others added4 commits

July 30, 2025 11:59

Apply suggestions from code review

3e03418

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

Change ignorePattern to plain RegExp

8185b21

Add related rules

0b6235f

Add ignorePattern example to no-v-html docs

79b608c

Copy link

ContributorAuthor

lucaswerkmeister commentedJul 30, 2025•
edited
Loading

(I’ve been adding commits under the assumption that you’ll squash them on merge and throw away the intermediate commit messages – let me know if you’d like the Git history cleaned up into a version that would be suitable for a merge commit ^^)

FloEdelmann reviewed

Jul 31, 2025

View reviewed changes

tests/lib/rules/no-v-html.js OutdatedShow resolvedHide resolved

docs/rules/no-v-html.md OutdatedShow resolvedHide resolved

lucaswerkmeister added2 commits

July 31, 2025 16:01

Make tests more strict

37c7542

Based onvuejs#2878.

Change tests+docs ignorePattern

90380c6

FloEdelmann requested a review fromCopilot

July 31, 2025 15:08

Merge branch 'master' into no-v-html-ignorePattern

83555ae

CopilotAI reviewed

Jul 31, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds anignorePattern configuration option to theno-v-html ESLint rule, allowing developers to allowlist variables with names matching a specific pattern for use with thev-html directive. This enables safer use ofv-html when variables are intentionally named to indicate they contain safe HTML content.

AddsignorePattern option to rule schema that accepts a regex pattern string
Implements logic to skip reporting violations when variable names match the configured pattern
Updates documentation with configuration examples and usage guidelines

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
lib/rules/no-v-html.js	Implements the ignorePattern option with regex matching logic
tests/lib/rules/no-v-html.js	Adds test cases for valid and invalid usage with ignorePattern option
docs/rules/no-v-html.md	Documents the new ignorePattern option with configuration examples
docs/rules/no-v-text.md	Adds related rules section for cross-referencing
docs/rules/no-v-text-v-html-on-component.md	Adds related rules section for cross-referencing
.changeset/purple-lights-invite.md	Documents the feature addition for changelog

lib/rules/no-v-html.jsShow resolvedHide resolved

FloEdelmann approved these changes

Jul 31, 2025

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for patiently implementing my feedback! 🙂
Looks good to me now 🙂

FloEdelmann requested review fromota-meshi andwaynzh

July 31, 2025 15:10

Update lib/rules/no-v-html.js

18fc869

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

waynzh approved these changes

Aug 1, 2025

View reviewed changes

Copy link

Member

waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks you!

waynzh merged commita198b52 intovuejs:master

Aug 1, 2025

4 checks passed

github-actionsbot mentioned this pull request

Aug 1, 2025

Version Packages#2910

Merged

lucaswerkmeister deleted the no-v-html-ignorePattern branch

August 1, 2025 09:59

Labels

None yet

Movatterモバイル変換

Uh oh!

feat: AddignorePattern tono-v-html#2857

feat: AddignorePattern tono-v-html#2857

Uh oh!

Conversation

lucaswerkmeister commentedJul 29, 2025

Uh oh!

changeset-botbot commentedJul 29, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

lucaswerkmeister commentedJul 29, 2025

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lucaswerkmeister commentedJul 30, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

waynzh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: Add`ignorePattern` to`no-v-html`#2857

feat: Add`ignorePattern` to`no-v-html`#2857

changeset-botbot commentedJul 29, 2025•
edited
Loading

lucaswerkmeister commentedJul 30, 2025•
edited
Loading