Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(func-call-spacing): remove obsolete compatibility code#2830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@ST-DDT
Copy link
Contributor

Continuation of#2793

This PR converts all error assertions forfunc-call-spacing to include both error message and full location checks.

@changeset-bot
Copy link

changeset-botbot commentedJul 25, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:776cef3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

FloEdelmann
FloEdelmann previously approved these changesJul 25, 2025
Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@FloEdelmannFloEdelmann dismissed theirstale reviewJuly 25, 2025 17:04

I missed that tests are failing

@ST-DDT
Copy link
ContributorAuthor

I removed the column property for now, so this is no longer blocked.
In the future, we should probably look into why this reports different locations depending on whether stylistic is present or not.

@ST-DDTST-DDT changed the titletest(func-call-spacing): make tests more stricttest(func-call-spacing): remove obsolete compatibility codeJul 30, 2025
Copy link
Member

@FloEdelmannFloEdelmann left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! I'll look into the differences. For reference:#2884

@FloEdelmannFloEdelmann merged commit87c7d83 intovuejs:masterJul 31, 2025
12 checks passed
@ST-DDTST-DDT deleted the test/strict/func-call-spacing branchJuly 31, 2025 18:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@waynzhwaynzhwaynzh left review comments

@FloEdelmannFloEdelmannFloEdelmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ST-DDT@FloEdelmann@waynzh
[8]ページ先頭
©2009-2025 Movatter.jp