Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork688
fix(block-lang): use consistent quotation marks in error messages#2805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Conversation
changeset-botbot commentedJul 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
🦋 Changeset detectedLatest commit:d411539 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means?Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thank you! I'd say this does qualify as afix, so thanks for adding a changeset! An issue is not required 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR standardizes quotation marks in error messages for thevue/block-lang ESLint rule to use single quotes consistently throughout. The changes address inconsistent usage of double quotes, single quotes, and backticks in error messages by converting all quotes to single quotes for better consistency.
- Standardized all quotation marks in error messages to use single quotes instead of mixed quote styles
- Updated test cases to reflect the new consistent error message format
- Added position information (endLine, endColumn) to test expectations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/rules/block-lang.js | Updated error message templates and helper function to use single quotes consistently |
| tests/lib/rules/block-lang.js | Updated test expectations to match new error message format and added missing position data |
| .changeset/strong-masks-fetch.md | Added changelog entry documenting the fix for inconsistent quotes |
Uh oh!
There was an error while loading.Please reload this page.
Follow-Up on#2804
While updating the tests, I noticed that the error messages use
",'and`for quoting/highlighting things.This PR changes this to only use
'.Does this qualify as
fix? Do I need to create an issue for this one?Blocked by#2804test(block-lang): make tests more strict #2804