Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(array-bracket-spacing): make tests more strict#2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

ST-DDT
Copy link
Contributor

Continuation of#2793

This PR converts all error assertions forarray-bracket-spacing to include both error message and full location checks.

@changeset-botchangeset-bot
Copy link

⚠️ No Changeset found

Latest commit:d8ccaa4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ST-DDT
Copy link
ContributorAuthor

ST-DDT commentedJul 18, 2025•
edited
Loading

Do you prefer these small PRs or would you prefer larger PRs?
How many test files should I update in one PR?

  • 1:1
  • 5:1
  • One PR for each starting letter
  • One PR for each starting word
  • All in one PR
  • Other?

I myself prefer small PRs as they have a lower chance of merge conflicts.
But I can understand, if this would cause issues on your side.

Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks! These small PRs are fine for me, but larger ones (like all rules starting with the same letter) would be fine, too.

@FloEdelmannFloEdelmann merged commit5bde25a intovuejs:masterJul 18, 2025
12 checks passed
@ST-DDTST-DDT deleted the test/strict/array-bracket-spacing branchJuly 18, 2025 12:35
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ST-DDT@FloEdelmann
[8]ページ先頭
©2009-2025 Movatter.jp