Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

test(no-deprecated-slot-attribute): make tests more strict#2793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ST-DDT
Copy link
Contributor

@ST-DDTST-DDT commentedJul 13, 2025•
edited
Loading

Continuation of#2773 (comment)

It might be helpful to include more detailed error information, such asline,column,endLine, andendColumn...

This PR converts all error assertions forno-deprecated-slot-attribute to include both error message and full location checks.

Is this kind of PR appreciated? If not, we can close it. If yes, I will create one for each rule one at a time.

@changeset-botchangeset-bot
Copy link

⚠️ No Changeset found

Latest commit:393149e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me. Better test coverage is always appreciated 🙂
Thank you!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ST-DDT@FloEdelmann
[8]ページ先頭
©2009-2025 Movatter.jp