Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork688
Migrate from Mocha to Vitest#2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
2nofa11 wants to merge8 commits intovuejs:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+59 −36
Open
Changes fromall commits
Commits
Show all changes
8 commits Select commitHold shift + click to select a range
060f779 chore:use codemod Mocha/Vitest/Recipe
2nofa11ca238e0 chore: migrate to vitest (manual support part)
2nofa1197312e7 chore: use vitest globals instead of imports in tests
2nofa119988933 chore: sort packages
2nofa1127f9f75 chore: update vitest configuration to refine test inclusion and exclu…
2nofa1122fba5a chore: remove obsolete Mocha configuration files
2nofa118d75589 chore: add launch configuration for Vitest testing in VSCode
2nofa1185cfbea chore: update vitest configuration to exclude additional integration …
2nofa11File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
14 changes: 11 additions & 3 deletions.vscode/launch.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,9 +5,17 @@ | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Start testing", | ||
waynzh marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| "program": "${workspaceFolder}/node_modules/.bin/vitest", | ||
| "args": ["run", "${file}", "--reporter=verbose"], | ||
| "console": "integratedTerminal" | ||
| }, | ||
| { | ||
| "type": "node", | ||
| "request": "launch", | ||
| "name": "Start testing (watch)", | ||
| "program": "${workspaceFolder}/node_modules/.bin/vitest", | ||
| "args": ["${file}", "--reporter=verbose"], | ||
| "console": "integratedTerminal" | ||
| } | ||
| ] | ||
| } | ||
2 changes: 1 addition & 1 deletioneslint.config.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
15 changes: 7 additions & 8 deletionspackage.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 changes: 0 additions & 5 deletionstests/.eslintrc.json
This file was deleted.
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
14 changes: 4 additions & 10 deletionstests/integrations/eslint-plugin-import.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -9,18 +9,12 @@ const cp = require('child_process') | ||
| const path = require('path') | ||
| const semver = require('semver') | ||
| const PLUGIN_DIR = path.join(__dirname, 'eslint-plugin-import') | ||
| const ESLINT = `.${path.sep}node_modules${path.sep}.bin${path.sep}eslint` | ||
| describe('Integration with eslint-plugin-import', () => { | ||
FloEdelmann marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| beforeAll(() => { | ||
| cp.execSync('npm i', { cwd: PLUGIN_DIR, stdio: 'inherit' }) | ||
FloEdelmann marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }) | ||
| // https://github.com/vuejs/eslint-plugin-vue/issues/21#issuecomment-308957697 | ||
| @@ -41,6 +35,6 @@ describe('Integration with eslint-plugin-import', () => { | ||
| return | ||
| } | ||
| cp.execSync(`${ESLINT} a.vue`, {cwd: PLUGIN_DIR,stdio: 'inherit' }) | ||
| }) | ||
| }) | ||
13 changes: 4 additions & 9 deletionstests/integrations/flat-config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,18 +5,12 @@ const cp = require('child_process') | ||
| const path = require('path') | ||
| const semver = require('semver') | ||
| const TARGET_DIR = path.join(__dirname, 'flat-config') | ||
| const ESLINT = `.${path.sep}node_modules${path.sep}.bin${path.sep}eslint` | ||
| describe('Integration with flat config', () => { | ||
| beforeAll(() => { | ||
| cp.execSync('npm i -f', { cwd: TARGET_DIR, stdio: 'inherit' }) | ||
FloEdelmann marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| }) | ||
| it('should lint without errors', () => { | ||
| @@ -33,6 +27,7 @@ describe('Integration with flat config', () => { | ||
| const result = JSON.parse( | ||
| cp.execSync(`${ESLINT} a.vue --format=json`, { | ||
| cwd: TARGET_DIR, | ||
| encoding: 'utf8' | ||
| }) | ||
| ) | ||
32 changes: 32 additions & 0 deletionsvitest.config.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| import { defineConfig } from 'vitest/config'; | ||
| export default defineConfig({ | ||
| test: { | ||
| include: [ | ||
| 'tests/lib/**/*.js', | ||
| 'tests/integrations/**/*.js' | ||
| ], | ||
| exclude: [ | ||
| '**/node_modules/**', | ||
| '**/dist/**', | ||
| 'tests/fixtures/**', | ||
| 'tests/integrations/flat-config/eslint.config.js', | ||
| 'tests/lib/rules/no-unsupported-features/utils.js' | ||
| ], | ||
| testTimeout: 60_000, | ||
| globals: true, | ||
| coverage: { | ||
| provider: 'v8', | ||
| include: ['lib/**/*.js'], | ||
| exclude: [ | ||
| 'tests/**', | ||
| 'dist/**', | ||
| 'tools/**', | ||
| 'node_modules/**' | ||
| ], | ||
| reporter: ['text', 'lcov', 'json-summary', 'html'], | ||
| all: true, | ||
| reportsDirectory: './coverage' | ||
| }, | ||
| }, | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.