vuejs/eslint-plugin-vuePublic

NotificationsYou must be signed in to change notification settings
Fork688
Star4.5k

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

waynzh merged 7 commits intovuejs:masterfromST-DDT:feat-2710-no-deprecated-slot-attribute-ignoreParents

Jul 13, 2025

Merged

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

waynzh merged 7 commits intovuejs:masterfromST-DDT:feat-2710-no-deprecated-slot-attribute-ignoreParents

Jul 13, 2025

Conversation

Copy link

Contributor

ST-DDT commentedJul 9, 2025•
edited
Loading

Adds#2710

vue/no-deprecated-slot-attribute conflicts with web component named slots #2710

Adds anignoreParents: string[] option tono-deprecated-slot-attribute to allow ignoring web-component usecases:

<template><web-component> <Entryslot="entry" /></web-component></template>

Preview:

Note to self: Next PR(s):

Increase the specificity of the rule test case assertionsfeat(no-deprecated-slot-attribute): regex ignore patterns #2773 (comment)

Copy link

changeset-botbot commentedJul 9, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:c94f13f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-vue	Minor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ST-DDT marked this pull request as ready for review

July 9, 2025 21:31

ST-DDT mentioned this pull request

Jul 9, 2025

vue/no-deprecated-slot-attribute conflicts with web component named slots#2710

Closed

2 tasks

ST-DDT commented

Jul 9, 2025

View reviewed changes

docs/rules/no-deprecated-slot-attribute.mdShow resolvedHide resolved

ST-DDT commented

Jul 9, 2025

View reviewed changes

docs/rules/no-deprecated-slot-attribute.mdShow resolvedHide resolved

FloEdelmann linked an issue

Jul 10, 2025

that may beclosed by this pull request

vue/no-deprecated-slot-attribute conflicts with web component named slots#2710

Closed

2 tasks

FloEdelmann reviewed

Jul 10, 2025

View reviewed changes

.changeset/beige-teams-camp.md OutdatedShow resolvedHide resolved

docs/rules/no-deprecated-slot-attribute.mdShow resolvedHide resolved

docs/rules/no-deprecated-slot-attribute.md OutdatedShow resolvedHide resolved

FloEdelmann approved these changes

Jul 11, 2025

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me now. Thank you! 🙂

FloEdelmann requested review fromota-meshi,waynzh andCopilot

July 11, 2025 10:47

CopilotAI reviewed

Jul 11, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

Adds anignoreParents option to theno-deprecated-slot-attribute rule so users can skip slot-attribute deprecation checks when a component is nested inside specified parent tags (e.g., web components).

IntroduceignoreParents in rule schema, parsing logic, and documentation
Extend tests to cover literal and regex-basedignoreParents matching
Update utility JSDoc to acceptVDocumentFragment inisVElement

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
tests/lib/rules/no-deprecated-slot-attribute.js	Add valid/invalid test cases for`ignoreParents`
lib/utils/index.js	Extend JSDoc for`isVElement` to include fragments
lib/rules/syntaxes/slot-attribute.js	Import and apply`ignoreParents` in reporting logic
lib/rules/no-deprecated-slot-attribute.js	Add`ignoreParents` to rule schema
docs/rules/no-deprecated-slot-attribute.md	Document the new`ignoreParents` option
.changeset/beige-teams-camp.md	Bump version with a minor release note

Comments suppressed due to low confidence (1)

docs/rules/no-deprecated-slot-attribute.md:53

[nitpick] Clarify that regex patterns inignoreParents are matched against the component’s raw tag name (which can be kebab-case or PascalCase). You may want to note that users should include case-insensitive flags or patterns to cover both formats.

- `"ignoreParents"` (`string[]`) An array of tags or regular expression patterns (e.g. `/^custom-/`) for parents that ignore these rules. This option is especially useful for [Web-Components](https://developer.mozilla.org/en-US/docs/Web/API/Web_components). Default is empty.

tests/lib/rules/no-deprecated-slot-attribute.jsShow resolvedHide resolved

waynzh approved these changes

Jul 13, 2025

View reviewed changes

Copy link

Member

waynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thank you!

ST-DDTand others added7 commits

July 13, 2025 15:50

feat(no-deprecated-slot-attribute): add ignoreParents option

257afca

docs: add changeset

870b0c7

docs: fix typos

5c770fa

Update .changeset/beige-teams-camp.md

b776597

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

docs: add links

c31e7e4

chore: only check exact case

42e0ca5

chore: rename var

c94f13f

waynzh force-pushed thefeat-2710-no-deprecated-slot-attribute-ignoreParents branch fromcba96ee toc94f13fCompare

July 13, 2025 07:50

waynzh merged commit9140c63 intovuejs:master

Jul 13, 2025

12 checks passed

github-actionsbot mentioned this pull request

Jul 13, 2025

Version Packages#2792

Draft

ST-DDT deleted the feat-2710-no-deprecated-slot-attribute-ignoreParents branch

July 13, 2025 14:23

Labels

None yet

3 participants

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

Uh oh!

Conversation

ST-DDT commentedJul 9, 2025•
edited
Loading

Uh oh!

Uh oh!

changeset-botbot commentedJul 9, 2025•
edited
Loading

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

waynzh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Movatterモバイル変換

Uh oh!

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

feat(no-deprecated-slot-attribute): add ignoreParents option#2784

Uh oh!

Conversation

ST-DDT commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

changeset-botbot commentedJul 9, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

waynzh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ST-DDT commentedJul 9, 2025•
edited
Loading

changeset-botbot commentedJul 9, 2025•
edited
Loading