Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: Use ESLint v9 in development env#2775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FloEdelmann merged 12 commits intomasterfromuse-eslintv9
Jul 2, 2025
Merged

Conversation

ota-meshi
Copy link
Member

@ota-meshiota-meshi commentedJul 1, 2025
edited
Loading

This PR will change the development environment to use ESLint v9.

After looking into the documentation build errors in#2770, I found that a lot of changes are needed.
I want to address those issues first with this PR.

Also, some tests were failing for the script-indent rule when using typescript-eslint v8, so I fixed those as well.

@changeset-botchangeset-bot
Copy link

changeset-botbot commentedJul 1, 2025
edited
Loading

🦋 Changeset detected

Latest commit:ab84a13

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
eslint-plugin-vueMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ota-meshiota-meshi marked this pull request as draftJuly 1, 2025 06:13
@ota-meshiota-meshi marked this pull request as ready for reviewJuly 1, 2025 07:04
@ota-meshi
Copy link
MemberAuthor

@2nofa11 Once this PR is merged, please rebase your PR 🙏

2nofa11 reacted with thumbs up emoji

@ota-meshiota-meshi requested a review fromwaynzhJuly 1, 2025 07:11
Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wow, thank you! Apart from two questions (which don't necessarily need to be resolved in context of this PR), this looks good to me.

I think this PR fixes#2756, right? So maybe@2nofa11 you want to have a look, too?

2nofa11 reacted with heart emoji
Copy link
Member

@waynzhwaynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

ota-meshi reacted with heart emoji
@FloEdelmannFloEdelmann linked an issueJul 1, 2025 that may beclosed by this pull request
4 tasks
Copy link
Contributor

@2nofa112nofa11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wow, thank you! Apart from two questions (which don't necessarily need to be resolved in context of this PR), this looks good to me.

I think this PR fixes#2756, right? So maybe@2nofa11 you want to have a look, too?

I’d love to take a look!
I’m still getting up to speed with the codebase, so I might have some beginner-level questions 😭

ota-meshi reacted with thumbs up emoji
Copy link
Contributor

@2nofa112nofa11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you 💯

ota-meshi reacted with heart emoji
Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me now. Thank you! 🙂

@FloEdelmannFloEdelmann merged commitebf6cb5 intomasterJul 2, 2025
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

@waynzhwaynzhwaynzh approved these changes

@2nofa112nofa112nofa11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade ESLint from v8 to v9
4 participants
@ota-meshi@FloEdelmann@waynzh@2nofa11

[8]ページ先頭

©2009-2025 Movatter.jp