Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(no-deprecated-slot-attribute): regex ignore patterns#2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@ST-DDT
Copy link
Contributor

@ST-DDTST-DDT commentedJun 28, 2025•
edited
Loading

Partiallyfixes#2710

Adds support for'/regex/' ignore patterns.

    <template>      <LinkList>        <oneslot="one" />        <twoslot="two" />        <my-componentslot="my-component-slot" />        <myComponentslot="myComponent-slot" />        <MyComponentslot="MyComponent-slot" />      </LinkList>    </template>
{ignore:['/one/','/^Two$/i','/^my-.*/i']}

Implementation based on#2734

@changeset-bot
Copy link

changeset-botbot commentedJun 28, 2025•
edited
Loading

🦋 Changeset detected

Latest commit:9d44658

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
eslint-plugin-vueMinor

Not sure what this means?Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ST-DDTST-DDT marked this pull request as ready for reviewJune 28, 2025 20:10
@ST-DDT
Copy link
ContributorAuthor

Tested with production code, kind of works as expected, with the limitations lined out here:

Copy link
Member

@waynzhwaynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, LGTM!
One small suggestion on tests.

Copy link
Member

@waynzhwaynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@waynzhwaynzh requested a review fromFloEdelmannJuly 1, 2025 08:22
ST-DDTand others added2 commitsJuly 1, 2025 10:42
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
ST-DDTand others added2 commitsJuly 1, 2025 12:17
Co-authored-by: Wayne Zhang <waynzh19@gmail.com>
Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me now, thank you 🙂

@FloEdelmannFloEdelmann merged commitfb4c1c0 intovuejs:masterJul 1, 2025
11 checks passed
@github-actionsgithub-actionsbot mentioned this pull requestJun 10, 2025
@ST-DDTST-DDT deleted the issue-2710/no-deprecated-slot-attribute/regex-ignore branchJuly 1, 2025 15:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@waynzhwaynzhwaynzh approved these changes

@FloEdelmannFloEdelmannFloEdelmann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

vue/no-deprecated-slot-attribute conflicts with web component named slots

3 participants

@ST-DDT@FloEdelmann@waynzh
[8]ページ先頭
©2009-2025 Movatter.jp