Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add newvue/prefer-define-component rule#2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
thesheppard wants to merge5 commits intovuejs:master
base:master
Choose a base branch
Loading
fromthesheppard:prefer-define-component

Conversation

thesheppard
Copy link
Contributor

@thesheppardthesheppard commentedApr 25, 2025•
edited
Loading

Thisresolves#2661

GeoffreyParrier reacted with heart emoji
Copy link

@absidueabsidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I would suggest reverting all of the formatting changes to the markdown files, as it makes the diff a lot larger than it needs to be, which makes it harder to review.

ota-meshi reacted with thumbs up emoji
@changeset-botchangeset-bot
Copy link

changeset-botbot commentedMay 31, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:7ac6c2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thesheppardthesheppard requested a review fromabsidueMay 31, 2025 14:08
@@ -546,6 +546,7 @@ The following rules extend the rules provided by ESLint itself and apply them to
[vue/padding-line-between-blocks]: ./padding-line-between-blocks.md
[vue/padding-line-between-tags]: ./padding-line-between-tags.md
[vue/padding-lines-in-component-definition]: ./padding-lines-in-component-definition.md
[vue/prefer-define-component]: ./prefer-define-component.md
Copy link
Member

@FloEdelmannFloEdelmannJun 2, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This link definition is now unused. Please runnpm run update to regenerate the docs, thenboth Markdownlint errors should be fixed.

@2nofa11
Copy link
Contributor

I noticed it's been about a month since the last update. Are you still planning to address the formatting feedback and add the changeset? If you're busy or would like help moving this forward, I'd be happy to assist 👍
(No pressure at all - just wanted to check in since this would be a valuable addition to the plugin.)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann left review comments

@absidueabsidueAwaiting requested review from absidue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce defineComponent for options API components with Typescript
4 participants
@thesheppard@2nofa11@FloEdelmann@absidue
[8]ページ先頭
©2009-2025 Movatter.jp