Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(no-multiple-template-root): support disallowComments property#2685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ota-meshi merged 6 commits intovuejs:masterfromchouchouji:feat-disallow-comments
Apr 29, 2025

Conversation

chouchouji
Copy link
Contributor

@chouchoujichouchouji commentedFeb 14, 2025•
edited
Loading

Issue

close#2316

@chouchouji
Copy link
ContributorAuthor

chouchouji commentedFeb 14, 2025•
edited
Loading

@FloEdelmann I am confused about how to determine if it is the comment of the root node. So I choose to filter invalid comments by node ranges. If you have better idea, please tell me. Thanks!

<template><!-- this is a comment--> // should report   <div>       123<!-- this is a comment--> // should not report   </div><!-- this is a comment--> // should report</template>

@chouchoujichouchoujiforce-pushed thefeat-disallow-comments branch 2 times, most recently fromd93ffe2 to0cd3dffCompareFebruary 15, 2025 07:58
@ota-meshiota-meshi marked this pull request as draftMarch 5, 2025 04:48
@chouchoujichouchouji marked this pull request as ready for reviewMarch 5, 2025 06:48
@chouchouji
Copy link
ContributorAuthor

@ota-meshi I updated docs and test cases. Please review it if you have time. Thanks.

Copy link
Member

@ota-meshiota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for this PR!

@chouchouji
Copy link
ContributorAuthor

Thank you for this PR!

Thanks for your review. I updated code and test cases.

Copy link
Member

@ota-meshiota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry for the late reply.
LGTM! Thanks!

chouchouji reacted with heart emoji
@ota-meshiota-meshi merged commitf8d0757 intovuejs:masterApr 29, 2025
11 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ota-meshiota-meshiota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vue/no-multiple-template-root false negative with comment
2 participants
@chouchouji@ota-meshi
[8]ページ先頭
©2009-2025 Movatter.jp