Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(no-ref-as-operand): useref.value to replaceref when emit#2680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
waynzh merged 8 commits intovuejs:masterfromchouchouji:feat-ref
Feb 20, 2025

Conversation

chouchouji
Copy link
Contributor

@chouchoujichouchouji commentedFeb 10, 2025•
edited
Loading

Issue

close#2601

mattjcj reacted with heart emoji
@chouchoujichouchouji changed the titlefeat(no-ref-as-operand): use value of ref to replace ref when emitfeat(no-ref-as-operand): useref.value to replaceref when emitFeb 10, 2025
Copy link
Member

@FloEdelmannFloEdelmann left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution! I now had a deeper look and apart from a few code maintenance/readbility improvements, it looks good to me 🙂

@chouchouji
Copy link
ContributorAuthor

Thanks for your contribution! I now had a deeper look and apart from a few code maintenance/readbility improvements, it looks good to me 🙂

Thanks for your reply! I had updated code.

Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for implementing the feedback so quickly! LGTM now.

@chouchouji
Copy link
ContributorAuthor

Thanks for implementing the feedback so quickly! LGTM now.

Thanks!

Copy link
Member

@waynzhwaynzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks!

chouchouji reacted with heart emoji
@waynzhwaynzh merged commitaf3700f intovuejs:masterFeb 20, 2025
12 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

@waynzhwaynzhwaynzh approved these changes

@ota-meshiota-meshiAwaiting requested review from ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal:no-ref-emit
3 participants
@chouchouji@FloEdelmann@waynzh
[8]ページ先頭
©2009-2025 Movatter.jp