Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork688
AddignoreProps
option tovue/prop-name-casing
#2679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
That makes sense to me. You can continue to add test cases and documentation when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, this is a good addition to the rule! I have a few comments though. Like@waynzh already said, please also add tests and documentation.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Flo Edelmann <git@flo-edelmann.de>
Fixed everything as we talked about. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Wayne Zhang <waynzh19@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Apart from one syntax error in the docs' example code, this looks good to me 🙂
Uh oh!
There was an error while loading.Please reload this page.
ignoreProps
option tovue/prop-name-casing
14450d2
intovuejs:masterUh oh!
There was an error while loading.Please reload this page.
Hi,
is this something you would be interested in - at least I did 😄 ?
If yes I would extend the test for it as well. If not then close it.
Thx
Patrick