Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork680
Deprecate Vue 2 only rules#2675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Closed
waynzh approved these changesFeb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
756715b
intov10 7 checks passed
Uh oh!
There was an error while loading.Please reload this page.
FloEdelmann added a commit that referenced this pull requestFeb 12, 2025
FloEdelmann added a commit that referenced this pull requestFeb 12, 2025
waynzh pushed a commit that referenced this pull requestFeb 20, 2025
ota-meshi pushed a commit that referenced this pull requestMar 5, 2025
ota-meshi pushed a commit that referenced this pull requestMar 5, 2025
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
These rules are currently in configs for Vue 2 (in all of
essential
,strongly-recommended
andrecommended
), but not in configs for Vue 3:→ could be useful as an uncategorized rule for Vue 3 to disallowcustom modifiers, so let's not deprecate it
→ could be useful as an uncategorized rule for Vue 3 to preventattribute inheritance problems, so let's not deprecate it
→ makes no sense for Vue 3, so deprecate it (seeVue 3 Migration Guide:
key
Attribute)→ makes no sense for Vue 3, so deprecate it (seeVue 3 Migration Guide:
v-model
)→ makes no sense for Vue 3, so deprecate it (seeVue 3 Migration Guide:
v-model
)→ makes no sense for Vue 3, so deprecate it (seeVue 3 Migration Guide:
v-model
)I didn't find anyuncategorized rules that would only be useful for Vue 2.
Note
These rules will continue to work fine in the upcoming major version
v10
, but no longer receive much maintenance work, and we'll remove them inv11
.Thus, deprecating them is not technically a breaking change, but I think it will receive more attention if we do it in a major version.