Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork700
Changevue-eslint-parser to peer dependency#2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
+4 −3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
vue-eslint-parser to peer dependencyFloEdelmann approved these changesJan 29, 2025
Member
FloEdelmann left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good idea!
be3ff99 intov10 14 checks passed
Uh oh!
There was an error while loading.Please reload this page.
FloEdelmann pushed a commit that referenced this pull requestJan 29, 2025
FloEdelmann pushed a commit that referenced this pull requestFeb 12, 2025
FloEdelmann pushed a commit that referenced this pull requestFeb 12, 2025
waynzh pushed a commit that referenced this pull requestFeb 20, 2025
ota-meshi added a commit that referenced this pull requestMar 5, 2025
ota-meshi added a commit that referenced this pull requestMar 5, 2025
Contributor
mbrodala commentedMar 5, 2025
For completeness: this does not work with Yarn which does not install peer dependencies by default but warns that they are missing: |
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes vue-eslint-parser to peer dependency.
I make it easy to change the version used by making vue-eslint-parser a peer dependency.
Also, recent npm installs peer dependencies automatically by default, so I don't think it will be inconvenient for users.