Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(require-explicit-slots): ignore attribute binding#2591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ota-meshi merged 5 commits intovuejs:masterfromwaynzh:fix/ignore-attribute-binding
Nov 11, 2024

Conversation

waynzh
Copy link
Member

@waynzhwaynzh commentedNov 2, 2024•
edited
Loading

fixes#2589.

Previously: Whennode.directive was true,slotName was incorrectly set to 'default', and it would check if it was explicitly defined.
Now: Ifnode.directive is true and is not string literal, the report is simply skipped.

Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, I only have one more minor comment.

Copy link
Member

@ota-meshiota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thank you very much for your contributions!

@ota-meshiota-meshi merged commite13089e intovuejs:masterNov 11, 2024
18 checks passed
@waynzhwaynzh deleted the fix/ignore-attribute-binding branchNovember 11, 2024 04:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

@ota-meshiota-meshiota-meshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

require-explicit-slots reports on slots with dynamic names
3 participants
@waynzh@FloEdelmann@ota-meshi
[8]ページ先頭
©2009-2025 Movatter.jp