Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork688
Fix Linter type import in index.d.ts#2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 tasks
FloEdelmann approved these changesOct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, this looks good!
Also, given there is already a duplicate PR (#2575), this seems to fix the issue for others as well.
aa476d6 intovuejs:master 18 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Thanks for adding TypeScript declarations in the latest v9.29.0.
I found an issue when using the new declaration. In the
lib/index.d.ts, theLinternamespace is pointing totypings/eslint/index.d.ts. However,typings/is not included in thefinal NPM package, therefore the declarations inindex.d.tsis not working.This issue can be fixed by adding a single line
import type { Linter } from 'eslint'as shown in this PR.Other code-styling changes included in this PR are made by Prettier based on
eslint-plugin-vue's Prettier config.Just FYI, the latest eslint has already includes TypeScript declarations, which means you don't need
@types/eslintand perhaps alsotypings/eslint/index.d.tsanymore onceeslint-plugin-vueupdated to the latest version of eslint (currentlyeslint-plugin-vueis still using eslint@8).