Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork688
fix(v-on-handler-style): fixed the breaking change caused by the auto-fix on functions without parameters(#2538)#2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
idCallExpr /* The statement is not a simple identifier call and cannot be fixed. */ && | ||
idCallExpr.arguments.length === 0 | ||
) { | ||
const paramCount = methodParamCountMap.get(idCallExpr.callee.name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this rule also has the number of arguments defined in the method. If we check that, I think some code can be safely fixed automatically.
If it's unsafe or we can't identify the number of arguments for the method, I think it's good to make it a suggestion.
Resolves#2538