Movatterモバイル変換

Skip to content

vuejs/eslint-plugin-vuePublic

NotificationsYou must be signed in to change notification settings
Fork680
Star4.5k

Fix detect Nuxt3 defineNuxtComponent#2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

FloEdelmann merged 7 commits intovuejs:v10fromsugitata:defineNuxtComponent

Nov 27, 2024

Merged

Fix detect Nuxt3 defineNuxtComponent#2311

FloEdelmann merged 7 commits intovuejs:v10fromsugitata:defineNuxtComponent

Nov 27, 2024

Conversation

sugitata

Copy link

Contributor

sugitata commentedNov 13, 2023•
edited by FloEdelmann
Loading

Description

It's just a workaround like solution.
Add thedefineNuxtComponent alias for Nuxt3 projects, similar to#1088.

About defineNuxtComponent

The difference betweendefineNuxtComponent anddefineComponent is onlyasyncData andhead options are added ondefineNuxtComponent.
These options are not essential to check in vue-eslint-plugin, so it should be fine to treat it asdefineComponent.

https://nuxt.com/docs/api/utils/define-nuxt-component

@sugitata

apply defineNuxtComponent

cd3e4b2

@sugitata

sugitata mentioned this pull request

vue/no-unused-properties does not work withdefineNuxtComponent()#2191

Closed

2 tasks

FloEdelmann

FloEdelmann reviewed

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your contribution!

lib/utils/index.js OutdatedShow resolvedHide resolved

FloEdelmann

FloEdelmann reviewed

View reviewed changes

tests/lib/rules/no-undef-components.jsShow resolvedHide resolved

sugitata added3 commits

November 14, 2023 20:02

@sugitata

fix: name

a269589

@sugitata

add tests

f091985

@sugitata

fix: indents

9924ad9

@sugitata

Copy link

ContributorAuthor

sugitata commentedNov 14, 2023

@FloEdelmann
Thank you for your review!
I fixed them.

FloEdelmann

FloEdelmann approved these changes

View reviewed changes

Copy link

Member

FloEdelmann left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM 🙂

@ota-meshi Should we consider this a breaking change and keep this for v10? (see#2166)

@FloEdelmann

FloEdelmann requested a review fromota-meshi

November 14, 2023 17:45

ota-meshi

ota-meshi approved these changes

View reviewed changes

Copy link

Member

ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Sorry for the late review.

@ota-meshi

Copy link

Member

ota-meshi commentedNov 29, 2023

Should we consider this a breaking change and keep this for v10?

Yeah. I think this should be included in v10.

@ota-meshi

ota-meshi added the semver-major label

@sugitata

Merge branch 'master' into defineNuxtComponent

20642ef

@ota-meshi

ota-meshi added the breaking change label

@ota-meshi

ota-meshi mentioned this pull request

vue/no-side-effects-in-computed-properties does not work withdefineNuxtComponent()nuxt/eslint#512

Open

@FloEdelmann

FloEdelmann changed the base branch frommaster tov10

November 27, 2024 11:08

FloEdelmann added2 commits

November 27, 2024 12:08

@FloEdelmann

Merge branch 'v10' into defineNuxtComponent

2b9b618

@FloEdelmann

Change parserOptions to languageOptions

701109d

@FloEdelmann

FloEdelmann merged commitd27c7e6 intovuejs:v10

6 checks passed

@FloEdelmann

FloEdelmann mentioned this pull request

Planning for v10#2166

Closed

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

5a1bb86

ota-meshi pushed a commit that referenced this pull request

@sugitata

@ota-meshi

Fix detect Nuxt3 defineNuxtComponent (#2311)

b090a6e

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

29c794e

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

9eba1d0

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

44e0cdb

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

4e1b4a9

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

9f1fc59

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

9a0b841

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

8c2cf0f

FloEdelmann pushed a commit that referenced this pull request

@sugitata

@FloEdelmann

Fix detect Nuxt3 defineNuxtComponent (#2311)

9418462

waynzh pushed a commit that referenced this pull request

@sugitata

@waynzh

Fix detect Nuxt3 defineNuxtComponent (#2311)

b60f2c7

ota-meshi pushed a commit that referenced this pull request

@sugitata

@ota-meshi

Fix detect Nuxt3 defineNuxtComponent (#2311)

31d37e7

ota-meshi pushed a commit that referenced this pull request

@sugitata

@ota-meshi

Fix detect Nuxt3 defineNuxtComponent (#2311)

5cb5fef

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

breaking change semver-major

3 participants

@sugitata

@ota-meshi

@FloEdelmann

[8]ページ先頭

©2009-2025 Movatter.jp