Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Addslots+expose tovue/order-in-components default order#2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
FloEdelmann merged 1 commit intov10fromorder-in-components
Dec 1, 2024

Conversation

ota-meshi
Copy link
Member

@ota-meshiota-meshi commentedMay 12, 2023•
edited by FloEdelmann
Loading

CathalMullan reacted with thumbs up emoji
@ota-meshiota-meshi marked this pull request as ready for reviewMay 12, 2023 05:05
Copy link
Member

@FloEdelmannFloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✔️ LGTM!

But since this is a breaking change, maybe we should first release a last v9.x version without this PR merged, so we don't force people to upgrade to a major version to use the new features.

Also, we could think about other breaking changes that we may want to accumulate into one v10 release.

ota-meshi reacted with thumbs up emoji
@ota-meshi
Copy link
MemberAuthor

ota-meshi commentedMay 12, 2023•
edited
Loading

Agree with you. I think this PR should be released with v10.

@ota-meshiota-meshi mentioned this pull requestMay 13, 2023
@FloEdelmannFloEdelmann changed the base branch frommaster tov10November 27, 2024 11:07
@FloEdelmann
Copy link
Member

@ota-meshi I changed the target branch tov10 now. Could you please resolve the conflicts so we can merge this?

@FloEdelmannFloEdelmann changed the titleChangevue/order-in-components rule to enforce ordering onslots andexpose defaultsAddslots+expose tovue/order-in-components default orderDec 1, 2024
@FloEdelmannFloEdelmann merged commit8c2961f intov10Dec 1, 2024
6 checks passed
@FloEdelmannFloEdelmann deleted the order-in-components branchDecember 1, 2024 11:43
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@FloEdelmannFloEdelmannFloEdelmann approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addslots tovue/order-in-components default order
2 participants
@ota-meshi@FloEdelmann
[8]ページ先頭
©2009-2025 Movatter.jp