vuejs/eslint-plugin-vuePublic

NotificationsYou must be signed in to change notification settings
Fork698
Star4.6k

Add`vue/v-on-handler-style` rule and deprecate`vue/v-on-function-call` rule#2009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

ota-meshi merged 18 commits intomasterfromv-on-handler-style

Oct 30, 2022

Merged

Add`vue/v-on-handler-style` rule and deprecate`vue/v-on-function-call` rule#2009

ota-meshi merged 18 commits intomasterfromv-on-handler-style

Oct 30, 2022

Conversation

Copy link

Member

ota-meshi commentedOct 12, 2022

This PR addsvue/v-on-handler-style rule.
And deprecatesvue/v-on-function-call rule.

close#2001

Addvue/v-on-handler-style rule and deprecated `vue/v-on-function-c…

f099cbc

…all` rule

ota-meshi requested a review fromFloEdelmann

October 12, 2022 04:53

FloEdelmann mentioned this pull request

Oct 12, 2022

WIP: Improvevue/v-on-function-call rule to check for functions#2006

Closed

FloEdelmann requested changes

Oct 12, 2022

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Preliminary review without having looked at the code yet.

docs/rules/v-on-handler-style.md OutdatedShow resolvedHide resolved

docs/rules/v-on-handler-style.mdShow resolvedHide resolved

tests/lib/rules/v-on-handler-style.js OutdatedShow resolvedHide resolved

ota-meshiand others added10 commits

October 12, 2022 16:54

Update docs/rules/v-on-handler-style.md

56fd2e9

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

Update docs/rules/v-on-handler-style.md

f76cfad

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

simplify element in doc

bc1f8c8

add related rules to doc

5bd54e9

add ignored examples to doc

e316a69

change to report morev

e9e9516

fix doc

194fe21

Merge branch 'master' into v-on-handler-style

cf2c89a

change v-on-handler-style

3395673

refactor

7296bc9

FloEdelmann requested changes

Oct 20, 2022

View reviewed changes

docs/rules/v-on-handler-style.mdShow resolvedHide resolved

docs/rules/v-on-handler-style.md OutdatedShow resolvedHide resolved

lib/rules/v-on-handler-style.jsShow resolvedHide resolved

lib/rules/v-on-handler-style.js OutdatedShow resolvedHide resolved

docs/rules/v-on-handler-style.mdShow resolvedHide resolved

ota-meshiand others added4 commits

October 26, 2022 17:59

Apply suggestions from code review

c0e2fe1

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

update docs

b471fd3

fix error message

7134914

Merge branch 'master' into v-on-handler-style

b5f4479

Copy link

MemberAuthor

ota-meshi commentedOct 26, 2022

Thank you for your review.
I made a change to this PR other than ignoreIncludesComment.

refactor

1b21be6

FloEdelmann reviewed

Oct 28, 2022

View reviewed changes

docs/rules/v-on-handler-style.md OutdatedShow resolvedHide resolved

docs/rules/v-on-handler-style.mdShow resolvedHide resolved

ota-meshiand others added2 commits

October 28, 2022 16:46

Update docs/rules/v-on-handler-style.md

6fd394d

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>

Merge branch 'master' into v-on-handler-style

fb42bb5

FloEdelmann approved these changes

Oct 28, 2022

View reviewed changes

Copy link

Member

FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✔️ LGTM

ota-meshi merged commitf5d700c intomaster

Oct 30, 2022

ota-meshi deleted the v-on-handler-style branch

October 30, 2022 14:26

This was referencedMay 16, 2023

Enforce style of passing an event or part of an event to a method#1611

Closed

"boundOnly" option forvue/v-on-function-call#1812

Closed

Labels

None yet

Movatterモバイル変換

Uh oh!

Addvue/v-on-handler-style rule and deprecatevue/v-on-function-call rule#2009

Addvue/v-on-handler-style rule and deprecatevue/v-on-function-call rule#2009

Uh oh!

Conversation

ota-meshi commentedOct 12, 2022

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ota-meshi commentedOct 26, 2022

Uh oh!

Uh oh!

Uh oh!

FloEdelmann left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add`vue/v-on-handler-style` rule and deprecate`vue/v-on-function-call` rule#2009

Add`vue/v-on-handler-style` rule and deprecate`vue/v-on-function-call` rule#2009