Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: fix to #750 :enhance devtools container management with mutatio…#752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
LukerSpringtree wants to merge2 commits intovuejs:main
base:main
Choose a base branch
Loading
fromLukerSpringtree:main

Conversation

@LukerSpringtree
Copy link
Contributor

fix this#750;

Add a ``MutationObserver` to resolve this scenario;

ferferga reacted with rocket emoji
@netlify
Copy link

netlifybot commentedDec 21, 2024•
edited
Loading

✅ Deploy Preview forvue-devtools-docs canceled.

NameLink
🔨 Latest commit0369952
🔍 Latest deploy loghttps://app.netlify.com/sites/vue-devtools-docs/deploys/6766aa028b7c0c0008ac7ed5

@pkg-pr-new
Copy link

pkg-pr-newbot commentedDec 21, 2024•
edited
Loading

Open in Stackblitz

@vue/devtools-applet

npm i https://pkg.pr.new/@vue/devtools-applet@752

@vue/devtools-core

npm i https://pkg.pr.new/@vue/devtools-core@752

@vue/devtools

npm i https://pkg.pr.new/@vue/devtools@752

@vue/devtools-api

npm i https://pkg.pr.new/@vue/devtools-api@752

@vue/devtools-kit

npm i https://pkg.pr.new/@vue/devtools-kit@752

vite-plugin-vue-devtools

npm i https://pkg.pr.new/vite-plugin-vue-devtools@752

commit:0369952

Comment on lines +32 to +34
if(app){
app.unmount()
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

withcreateDevToolsContainer (line 21) appending the devtool app in the DOM, wouldn't this systematically trigger ? making the callback unmount and re-mount the app for nothing ?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@Ragnar-OockRagnar-OockRagnar-Oock left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LukerSpringtree@Ragnar-Oock
[8]ページ先頭
©2009-2025 Movatter.jp