Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: base template align node version with vite 7#775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
haoqunjiang merged 1 commit intomainfromchore/base-template-align-node-version
Jul 15, 2025

Conversation

btea
Copy link
Collaborator

@bteabtea commentedJul 1, 2025

Description

sync#774

@bteabtea requested a review fromcexbrayatJuly 7, 2025 05:33
Copy link
Member

@cexbrayatcexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm fine with this, but I'll let@haoqunjiang decide if we want to maintain this in sync

@haoqunjiang
Copy link
Member

I thinknpm install and similar commands would already throw on unsupported Node versions when the package manager tries to install vite? If so, we don't need to add this to the template explicitly. It doesn't add any new information to the project, yet it may become a maintenance burden in the future.

@btea
Copy link
CollaboratorAuthor

I now use Node 18 to runpnpm create vue to create a project and executepnpm i, and no errors or prompts appear. It is not untilpnpm dev is executed that the error appears.

Therefore, if the required node version information is added to package.json, the user can be informed more clearly of the reason.

In fact, after Vite released 7, many people encountered this problem and raised issues.

@haoqunjiang
Copy link
Member

Thanks. I took some further tests. It seems thatpnpm create doesn't check theengines field ofcreate-vue, andpnpm install ignores those in the dependencies, whilenpm warns in both cases.
Including an explicitengines field in the created project'spackage.json is indeed beneficial for users ofpnpm.

btea reacted with rocket emoji

@haoqunjianghaoqunjiang merged commit106c269 intomainJul 15, 2025
104 checks passed
@bteabtea deleted the chore/base-template-align-node-version branchJuly 15, 2025 09:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cexbrayatcexbrayatcexbrayat left review comments

@haoqunjianghaoqunjianghaoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@btea@haoqunjiang@cexbrayat

[8]ページ先頭

©2009-2025 Movatter.jp