Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat!: use a giant multiselect instead of individual toggles for features#695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
haoqunjiang merged 12 commits intovuejs:mainfromhaoqunjiang:feat-multiselect
Mar 7, 2025

Conversation

haoqunjiang
Copy link
Member

@haoqunjianghaoqunjiang commentedFeb 18, 2025
edited
Loading

As we are adding more features, the number of toggles is getting out of hand. A multiselect could save a few keystrokes for most users.

I also take this opportunity to change the prompts library to@clack/prompts.
(For context:create-astro,sv,create-preact,create-solid,create-qwik all use@clack/prompts,create-vite recently switched to@clack/prompts too, whilecreate-next-app usesprompts)

The color library is changed topicocolors. IMOkleur is still the smaller library because of treeshaking. But@clack/prompts already comes withpicocolors as a dependency, so by not addingkleur, we save a few bytes.


This is a proof-of-concept PR. I haven't put much consideration into the code style yet. Nor have I updated the i18n messages. I will do that if this change is accepted.

See the result in a screen recording:
asciicast

TODOs:

  • Clean up the code (wrap theisCancel condition; update theneedsEslint type, etc.)
  • I think we should remove thepackageName related logic but it can be postponed into another PR
  • Get the message translations reviewed

Yordan-Ramchev reacted with rocket emoji
…uresAs we are adding more features, the number of toggles is getting out of hand.A multiselect could save a few keystrokes for most users.I also take this opportunity to change the prompts library to `@clack/prompts`.The color library is changed to `picocolors`. IMO `kleur` is still the smallerlibrary because of treeshaking. But `@clack/prompts` already comes with`picocolors` as a dependency, so by not adding `kleur`, we save a few bytes.This is a proof-of-concept change. I haven't put much consideration into thecode style yet. Nor have I updated the i18n messages. I will do that if thischange is accepted.See the result in a screen recording:[![asciicast](https://asciinema.org/a/lPaZSGz9LTd7mcWZeJAZxerhx.svg)](https://asciinema.org/a/lPaZSGz9LTd7mcWZeJAZxerhx)
… ci]Still much work to do. But it's acdceptable for now.
Copy link
Member

@cexbrayatcexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, I like the idea 👍

@haoqunjianghaoqunjiang marked this pull request as ready for reviewFebruary 28, 2025 10:14
@haoqunjiang
Copy link
MemberAuthor

haoqunjiang commentedFeb 28, 2025
edited
Loading

I think this PR is ready for review. I can confirm the flags parsing behavior is exactly same, but I can only manually test the prompt parsing, so far it seems good.

@cexbrayat@btea Do the new prompt messages look good to you?
If so, would you please help review the French translation of the new messages@cexbrayat ? They were translated by Claude 3.5 Sonnet, I'm not sure if I can trust it.

Copy link
Collaborator

@bteabtea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@haoqunjiang
Copy link
MemberAuthor

Merging this PR now as I'm going to do another round of dependency maintenance and release a new version tomorrow.

@haoqunjianghaoqunjiang merged commit3aaddc6 intovuejs:mainMar 7, 2025
52 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cexbrayatcexbrayatcexbrayat approved these changes

@bteabteabtea approved these changes

@yyx990803yyx990803Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@haoqunjiang@cexbrayat@btea

[8]ページ先頭

©2009-2025 Movatter.jp