- Notifications
You must be signed in to change notification settings - Fork504
feat!: use a giant multiselect instead of individual toggles for features#695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…uresAs we are adding more features, the number of toggles is getting out of hand.A multiselect could save a few keystrokes for most users.I also take this opportunity to change the prompts library to `@clack/prompts`.The color library is changed to `picocolors`. IMO `kleur` is still the smallerlibrary because of treeshaking. But `@clack/prompts` already comes with`picocolors` as a dependency, so by not adding `kleur`, we save a few bytes.This is a proof-of-concept change. I haven't put much consideration into thecode style yet. Nor have I updated the i18n messages. I will do that if thischange is accepted.See the result in a screen recording:[](https://asciinema.org/a/lPaZSGz9LTd7mcWZeJAZxerhx)
… ci]Still much work to do. But it's acdceptable for now.
cexbrayat left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good, I like the idea 👍
Uh oh!
There was an error while loading.Please reload this page.
haoqunjiang commentedFeb 28, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I think this PR is ready for review. I can confirm the flags parsing behavior is exactly same, but I can only manually test the prompt parsing, so far it seems good. @cexbrayat@btea Do the new prompt messages look good to you? |
btea left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
haoqunjiang commentedMar 7, 2025
Merging this PR now as I'm going to do another round of dependency maintenance and release a new version tomorrow. |
3aaddc6 intovuejs:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
As we are adding more features, the number of toggles is getting out of hand. A multiselect could save a few keystrokes for most users.
I also take this opportunity to change the prompts library to
@clack/prompts.(For context:
create-astro,sv,create-preact,create-solid,create-qwikall use@clack/prompts,create-viterecently switched to@clack/promptstoo, whilecreate-next-appusesprompts)The color library is changed to
picocolors. IMOkleuris still the smaller library because of treeshaking. But@clack/promptsalready comes withpicocolorsas a dependency, so by not addingkleur, we save a few bytes.This is a proof-of-concept PR. I haven't put much consideration into the code style yet. Nor have I updated the i18n messages. I will do that if this change is accepted.
See the result in a screen recording:

TODOs:
isCancelcondition; update theneedsEslinttype, etc.)packageNamerelated logic but it can be postponed into another PR