- Notifications
You must be signed in to change notification settings - Fork476
feat: add--eslint-with-oxlint
and--prettier
feature flags#682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
haoqunjiang merged 14 commits intovuejs:mainfromhaoqunjiang:feat-oxlint-and-prettier-feature-flagsFeb 18, 2025
Merged
feat: add--eslint-with-oxlint
and--prettier
feature flags#682
haoqunjiang merged 14 commits intovuejs:mainfromhaoqunjiang:feat-oxlint-and-prettier-feature-flagsFeb 18, 2025
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This reverts commitb51c033.
TBH this isn't ideal. The only bottleneck in the build job is thesnapshot step, moving it to the verification jobs defeats the purpose ofhaving a separate build job.I'll fix it later by trying to use tar.
cexbrayat approved these changesFeb 18, 2025
8208ca2
intovuejs:main 52 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I started with adding
--eslint-with-oxlint
but found it didn't make sense without a standalone--prettier
flag.To achieve that I had to duplicate some logic from
@vue/create-eslint-config
but I think it's acceptable as it's just a few lines of templates, the complex logic about eslint integration still resides in@vue/create-eslint-config
.The downside is that the playground got bloated bya lot. I tried to speed up the CI, but it's still slower than previous and there isn't much I can do here, there's an inherent complexity in running tests on more than a thousand projects.