- Notifications
You must be signed in to change notification settings - Fork476
fix: add eslint.config.* to tsconfig.node.json and fix other eslint issues#669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ESLint 9.18 unflagged `eslint.config.ts` support, therefore it'snecessary to add `eslint.config.*` to `tsconfig.node.json` to avoidtypescript-eslint raising error on that file.
Previously we don't generate all possible combinations of flags foreslint, therefore missing this bug in typescript-eslint projects.I wanted to add snapshots for prettier feature too, but it currentlyis a bit messy, I need to refactor that part first.
I don't want to use@ts-expect-error here because eslint-plugin-cypresscould add some types in the future and that shouldn't cause errors.
It's too much work to get them work together out of box, so let's skip
dcde963
intovuejs:main 52 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint 9.18 unflagged
eslint.config.ts
support, therefore it's necessary to addeslint.config.*
totsconfig.node.json
to avoid typescript-eslint raising error on that file.