Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: simplify CI matrix and more comprehensive tests#640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
haoqunjiang merged 35 commits intovuejs:mainfromhaoqunjiang:ci-simplify-matrix
Dec 19, 2024

Conversation

haoqunjiang
Copy link
Member

@haoqunjianghaoqunjiang commentedDec 18, 2024
edited
Loading

Description

Simplify the CI pipeline for a cleaner workflow; and avoid the parallelism limit when we add more flags to the CLI.

Most of the time, the new workflow's total duration would be shorter or similar to the previous one (longer job execution time but less queueing time1), but sometimes, Windows Cypress tests took too long when cache misses.

TODOs:

  • separatetypescript-* projects from others because type-checking takes much more time
  • add node 18/20 jobs
  • add tests for Nightwatch I didn't manage to get Nightwatch tests working on GitHub Actions. It was never tested before anyway, so let's skip that for this PR.
  • Add more snapshots for ESLint / Prettier, now that they won't trigger more jobs in the CI matrix.
    I'd like to move that into a separate PR because it requires changing the snapshot script, so not a mere CI change.
  • fix--with-tests. That should also be a separate PR.

TO DECIDE:

  • Shall we scope down the Node.js 18/20 tests to only make sure that the project can be successfully created and dependencies can be installed withengine-strict flag on? Because most of the actual compatibility work is on the shoulder of the upstream projects, not us.

Footnotes

  1. there can be only 20 concurrent jobs onGitHub Free plan

as ts tries to search upwards and found the depended `tsconfig/node22`dep missing
This reverts commit04af4bb.It would took too much effort to make it work. We can revisit it later.It's never tested before anyway.
@haoqunjianghaoqunjiang marked this pull request as ready for reviewDecember 19, 2024 08:59
@haoqunjianghaoqunjiang changed the titleci(work-in-progress): simplify CI matrix and more comprehensive testsci: simplify CI matrix and more comprehensive testsDec 19, 2024
@haoqunjianghaoqunjiang merged commit93223ad intovuejs:mainDec 19, 2024
52 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cexbrayatcexbrayatcexbrayat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@haoqunjiang@cexbrayat

[8]ページ先頭

©2009-2025 Movatter.jp