- Notifications
You must be signed in to change notification settings - Fork476
fix: removecomposite: true from tsconfigs#635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We are only using `references` in a solution-style tsconfig.According to discussions atmicrosoft/TypeScript#60465,such usage doesn't require `composite: true` to be set in sub-configs.Removing this field loosens the constraints on these configs that allfiles to be explicitly listed in `files` or `includes`.After this change, type errors in source code would only be reportedtwice if they're also imported by unit test specs, in contrast toalways be reported twice prior to the change.I know this is not ideal yet, but it's still an improvement, and mighthelp catch some edge cases such asvuejs#437 (comment)In the long run, we should still keep an eye onvuejs#549(pendingvuejs/language-tools#4750).Cross-referencing might be a more intuitive configuration, and should bethe desirable configuration if we opt into Vitest Browser Mode.
cexbrayat approved these changesDec 12, 2024
24fc23b intovuejs:main 101 checks passed
Uh oh!
There was an error while loading.Please reload this page.
charnog commentedJan 20, 2025
@haoqunjiang to keep you informed about the implications of this PR. There was a "Heisenbug" issue about |
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Description
We are only using
referencesin a solution-style tsconfig. According to discussions atmicrosoft/TypeScript#60465, such usage doesn't requirecomposite: trueto be set in sub-configs.Removing this field loosens the constraints on these configs that all checked files to be explicitly listed in
filesorincludes.After this change, type errors in source code would only be reported twice if they're also imported by unit test specs, in contrast to always be reported twice prior to the change.
I know this is not ideal yet, but it's still an improvement, and might help catch some edge cases such as#437 (comment)
In the long run, we should still keep an eye on#549 (pendingvuejs/language-tools#4750). Cross-referencing might be a more intuitive configuration, and should be the desirable configuration if we opt into Vitest Browser Mode.