Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add tailwind support#416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
Yordan-Ramchev wants to merge3 commits intovuejs:mainfromYordan-Ramchev:add-tailwind-option
Closed

feat: add tailwind support#416

Yordan-Ramchev wants to merge3 commits intovuejs:mainfromYordan-Ramchev:add-tailwind-option

Conversation

Yordan-Ramchev
Copy link
Contributor

@Yordan-RamchevYordan-Ramchev commentedDec 30, 2023
edited
Loading

Hi@sodatea@cexbrayat,

I've opened a pull request(re#246) that introduces:

  1. Introduced Tailwind prompt functionality with an untranslated prompt message.
  2. Ensured compatibility for both JavaScript (js) and TypeScript (ts) scenarios.
  3. Modified generateReadme.ts for necessary updates.
  4. Incorporated the Tailwind feature flag into snapshot.mjs.

I would appreciate your time and expertise in reviewing these changes.

Thank you!

@bmulholland
Copy link

One concern is that the approach athttps://github.com/vuejs/create-vue-templates isn! on the number of options. Probably also the CI matrices? There's already a lot of directories in that repo, and over 100 CI checks... at what point will that approach break down?

I recognize that this is not about your code itself, but about the practicalities of maintaining all combinations of options.

At a minimum, you probably need to add the tailwind option tohttps://github.com/vuejs/create-vue/blob/main/.github/workflows/ci.yml

Yordan-Ramchev reacted with thumbs up emoji

@Yordan-Ramchev
Copy link
ContributorAuthor

Yordan-Ramchev commentedJan 2, 2024
edited
Loading

@bmulholland thank you for the feedback. I have added tailwind flag in CI and that's (n! on the number of options) a reasonable concern

bmulholland reacted with thumbs up emoji

@cexbrayat
Copy link
Member

cexbrayat commentedJan 25, 2024
edited
Loading

Note: this PR is a duplicate of an older PR#245 If one of the two is merged, the other can be closed.

I personally don't think it's worth the added complexity to add tailwind support, but I'll let@sodatea decide.

@Yordan-RamchevYordan-Ramchev deleted the add-tailwind-option branchFebruary 23, 2024 15:21
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Yordan-Ramchev@bmulholland@cexbrayat

[8]ページ先頭

©2009-2025 Movatter.jp