Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: Correct the 'build' command in the package.json file.#394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mishengqiang wants to merge1 commit intovuejs:main
base:main
Choose a base branch
Loading
frommishengqiang:patch-1

Conversation

mishengqiang
Copy link

@mishengqiangmishengqiang commentedNov 30, 2023•
edited
Loading

The package.json file is located at template/config/typescript/package.json.

run-p type-check \"build-only {@}\" -- ->run-p type-check \"build-only -- {@}\" --

#393

The package.json file is located at template/config/typescript/package.json.
@mishengqiangmishengqiang changed the titleCorrect the 'build' command in the package.json file.fix: Correct the 'build' command in the package.json file.Nov 30, 2023
Copy link
Member

@cexbrayatcexbrayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It fixes commands likenpm run build -- --sourcemap, but it no longer works withpnpm run build --sourcemap because it adds an extra--

@sodatea WDYT?

marcosdissotti reacted with thumbs up emoji
@mishengqiang
Copy link
Author

Ah, I didn't consider pnpm and yarn. After testing, yarn performs the best – it passes parameters as expected regardless of whether-- is added or not. npm requires an extra-- to pass parameters as expected. pnpm doesn't need an extra-- to pass parameters as expected.

image

The image below demonstrates when an extra '--' is added.
image

@cexbrayat
Copy link
Member

Yes, that's why I don't know if we should change the default or not, or maybe there is a way to make it work with all package managers?

@haoqunjiang
Copy link
Member

Yeah, I think this should be resolved in the upstreamnpm-run-all2 package instead.
Before that, maybe we can add a note in the generated README?

@ayu-exorcist
Copy link

Yeah, I think this should be resolved in the upstreamnpm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in thebcomnes/npm-run-all2#143.

We can runrun-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

Yordan-Ramchev reacted with heart emoji

@ayu-exorcist
Copy link

ayu-exorcist commentedJul 4, 2024•
edited
Loading

Yeah, I think this should be resolved in the upstreamnpm-run-all2 package instead. Before that, maybe we can add a note in the generated README?

I resolved it in thebcomnes/npm-run-all2#143.

We can runrun-p type-check \"build-only -- {@}\" -- on npm/yarn/pnpm when the PR is merged

Already merged innpm-run-all2 v6.2.1

We can try to merge this PR now!

@bcomnes
Copy link

Turns out this was a breaking change so I reverted. I need to consider this change a little bit more and at a minimum, put it out in a major release with notes on upgrading.

ayu-exorcist and messenjer reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@cexbrayatcexbrayatcexbrayat left review comments

@haoqunjianghaoqunjiangAwaiting requested review from haoqunjiang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@mishengqiang@cexbrayat@haoqunjiang@ayu-exorcist@bcomnes
[8]ページ先頭
©2009-2025 Movatter.jp