- Notifications
You must be signed in to change notification settings - Fork479
feat: use type=module in generated projects#389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Closed
Closed
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The generated applications were failing out of the box, and went unnoticed as nightwatch is not built on CI.I took inspiration fromhttps://github.com/nightwatchjs/nightwatch-plugin-vue andhttps://github.com/nightwatchjs/create-nightwatch to make the setup a bit lighter and functional (we now let nightwatch start vite directly).The pnpm test script should now work for every combination generated.
For Cypress with Typescript, we needed to add a `module` option to the root tsconfig (seecypress-io/cypress#24111).
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR is blocked for now because of:
The PR is on top of#386
The current strategy is to use
type: modulein the package.json file to avoid the CJS warning from Vite 5.This forces us to:
.jsto.cjs"module": "es2015"to the compiler options in TS/Cypress projects as mentioned inCypress fails to run when type ismodulecypress-io/cypress#24111