fix: nightwatch integration#386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

haoqunjiang merged 1 commit intovuejs:mainfromcexbrayat:fix/nighwatch

Nov 27, 2023

Merged

fix: nightwatch integration#386

haoqunjiang merged 1 commit intovuejs:mainfromcexbrayat:fix/nighwatch

Nov 27, 2023

Conversation

Copy link

Member

cexbrayat commentedNov 24, 2023

The generated applications were failing out of the box, and went unnoticed as nightwatch is not built on CI.

I took inspiration fromhttps://github.com/nightwatchjs/nightwatch-plugin-vue andhttps://github.com/nightwatchjs/create-nightwatch to make the setup a bit lighter and functional (we now let nightwatch start vite directly).

The pnpm test script should now work for every combination generated.

cexbrayat requested a review fromhaoqunjiang

November 24, 2023 16:27

cexbrayat mentioned this pull request

Nov 26, 2023

feat: use type=module in generated projects#389

Closed

1 task

haoqunjiang requested changes

Nov 27, 2023

View reviewed changes

template/tsconfig/nightwatch/nightwatch/tsconfig.json OutdatedShow resolvedHide resolved

fix: nightwatch integration

14a2bf5

The generated applications were failing out of the box, and went unnoticed as nightwatch is not built on CI.I took inspiration fromhttps://github.com/nightwatchjs/nightwatch-plugin-vue andhttps://github.com/nightwatchjs/create-nightwatch to make the setup a bit lighter and functional (we now let nightwatch start vite directly).The pnpm test script should now work for every combination generated.