- Notifications
You must be signed in to change notification settings - Fork477
fix: use--build
for type-checking to be exhaustive and less-fragile#274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fixes#267Thanks@segevfiner for noticing this new feature!Currently there's still a small annoyance that `vue-tsc` would outputan extra error message when there're type errors in `.vue` filesvuejs/language-tools#2622 But it works wellif there's no error.I've already submitted a PR to address itvuejs/language-tools#3176
segevfiner commentedMay 12, 2023
Actually, they might have changed things so that it does run but doesn't type check packages with Be sure we actually get errors with this. I have requestedmicrosoft/TypeScript#53979 for them to make this work. |
What do you mean by "might have changed things"? I tested this projecthttps://github.com/sodatea/no-emit-test with both 5.0.4 and 5.1.0-dev.20230512, both reporting the same correct number of errors - though in subsequent calls the error location is lost for |
Fixes#267It's because I moved the `compilerOptions` from `tsconfig.json` to`tsconfig.app.json` in the 2023-05-05 (v3.6.2) release, but forgot tochange the `type-check` script.This isn't comprehensive because it doesn't check all the sub-projects,but at least it's the same scope as previous versions.Ideally I hope#274 can work reliably. But now I'm not sure. So let'sfirst fix this bug.
|
segevfiner commentedMay 12, 2023
I tried configuring this myself once before but got no errors, but maybe I did something wrong or it was a different issue. |
segevfiner commentedMay 12, 2023
It might have been the |
haoqunjiang commentedNov 27, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@cexbrayat This change could help catch the issue in#386 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I gave it a try, and I think it works well 👍
One note though: all the errors are logged twice. But I'm not sure if this is really an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks liketypescript-jsx-nightwatch
is failing when runningpnpm test
locally. There is probably anoEmit
to add in another file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
--build
for type-checking to be exaustive and less-fragile--build
for type-checking to be exhaustive and less-fragilebmulholland commentedDec 5, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
FYI: I think this setting is incompatible with any JS in the project. I have some legacy JS files in my app, so I have allowJS: true. If I try running type checking, I get "js emit is not supported." And if I add |
- 'vue-tsc' uses '--build' because we are using 'references' in tsconfig.json.- 'vue-tsc' doesn't use '--noEmit' because it is incompatible with '--build'. Instead we set 'noEmit' to 'true' in the referenced tsconfig.json files.- 'vue-tsc' uses '--force' to make check-only builds more reliable (seevuejs/create-vue#274).
* Add package.json* Add 'node_modules' to .gitignore* Add 'typescript' to dev dependencies* Configure TypeScript for Vue* Configure TypeScript for Vite* Set 'composite' in tsconfig.*.jsonAccording to the documentation, the 'composite' option should be set to'true' for referenced projects.* Add Vite's client-side types to tsconfig.dom.json* Add 'vite' to dev dependencies* Add favicon.ico mock* Add index.html* Add vite.config.ts* Fix tsconfig.dom.json* Add Vite scripts* Use a relative import for main.ts in index.html- The main.ts reference is fundamentally different from the favicon.ico reference, Vite resolves references like this similarly to how JavaScript imports are resolved.- '@/main.ts' in index.html that uses 'resolve.alias' works properly for the production build but doesn't work for the development server.* Add 'vue-tsc' to dev dependencies* Add 'vue' to dependencies* Add '@vitejs/plugin-vue' to dev dependencies* Add App.vue, main.ts* Add '@types/node' to dev dependenciesFixes TypeScript's "Cannot find type definition file for 'node'".* Fix 'compilerOptions.paths' in tsconfig.dom.jsonFixes TypeScript's "Non-relative paths are not allowed when 'baseUrl' is notset. Did you forget a leading './'?"* Set 'noEmit' in referenced tsconfig.json filesThis makes it possible to perform check-only builds of a project thatuses 'references' in tsconfig.json. The '--noEmit' flag cannot be usedhere because it is incompatible with '--build'. Check-only builds areespecially important for 'vue-tsc' as it doesn't support emitting files.* Add '*.tsbuildinfo' to .gitignore* Add 'lint' script to package.json- 'vue-tsc' uses '--build' because we are using 'references' in tsconfig.json.- 'vue-tsc' doesn't use '--noEmit' because it is incompatible with '--build'. Instead we set 'noEmit' to 'true' in the referenced tsconfig.json files.- 'vue-tsc' uses '--force' to make check-only builds more reliable (seevuejs/create-vue#274).* Add 'eslint', 'eslint-plugin-vue', 'typescript-eslint' to dev dependencies* Allow JavaScript to be checked in tsconfig.node.json* Add eslint.config.js* Add ESLint configuration recommended by 'typescript-eslint'* Add '@types/eslint__js' to dev dependencies* Stop using 'types' in tsconfig.json filesBecause unfortunately, they don't work as expected.* Enhance ESLint with type information- '...tseslint.configs.recommendedTypeChecked' enables enhanced linting with type information.- 'languageOptions.parserOptions.EXPERIMENTAL_useProjectService: true' allows 'typescript-eslint' to compute type information for a TypeScript project that uses 'references' in the tsconfig.json file (seetypescript-eslint/typescript-eslint#2094).* Add 'vue-eslint-parser' to dev dependencies* Clean up eslint.config.js* Include local type definitions in the project* Declare 'eslint-plugin-vue' module* Clean up eslint.config.js* Add '@eslint/eslintrc' to dev dependencies* Add '@types/eslint__eslintrc' to dev dependencies* Configure ESLint for Vue- 'eslint-plugin-vue' doesn't support flat configuration yet, therefore we rely on '@eslint/eslintrc' to use Vue's recommended configuration.* Remove 'eslint-plugin-vue' module declarationIt is no longer directly imported in the project, so types are notneeded.* Ignore a ESLint error regarding 'App.vue' being 'any'* Add 'eslint-config-prettier' to dev dependencies* Add 'prettier' to dev dependencies* Add '@types/eslint-config-prettier' to dev dependencies* Remove 'lint' from scripts* Add 'check', 'format' to scripts* Add Prettier's ESLint config* Remove custom types from tsconfig.*.json* Clean up tsconfig.node.json* Remove 'types' field from tsconfig.json files* Factor out tsconfig.base.json* Add env.dom.d.ts* Add 'tailwindcss', 'postcss', 'autoprefixer' to dev dependencies* Initialize PostCSS and Tailwind* Configure HTML template files for Tailwind* Format* Add types to postcss.config.js* Add the Tailwind directives to style.css* Add style.css import to main.ts* Add Tailwind CSS Prettier plugin* Add 'dist' to .gitignore* Enable reporting of unused disable directives in ESLint* Add vue-router to dependencies* Add router* Add pinia to dependencies* Add Pinia* Ignore dist in eslint* Add @eslint/js to dev dependencies* Suppress the createApp eslint error* Remove the counter store
Uh oh!
There was an error while loading.Please reload this page.
Fixes#267
Closes#181
Thanks@segevfiner for noticing this new feature!
Currently there's still a small annoyance thatvue-tsc
would output an extra error message when there're type errors in.vue
filesvuejs/language-tools#2622 But it works well if there's no error.I've already submitted a PR to address itvuejs/language-tools#3176