Commitbb11f04

committed

fix: prioritize enviornment variables over Intl.DateTimeFormat

While `Intl.DateTimeFormat` should be the most reliable way to get theuser's locale, it lacks flexibility.For example, on Windows PowerShell, there's no way to change thedetection result in-session (you have to logout and login again).So in order to provide an escape hatch for developers and users whowant to temporarily change the locale, we prioritize environmentvariables over `Intl.DateTimeFormat`.In POSIX shells, you can do `LANG=zh_CN.UTF-8` to change the locale toChinese;In CMD, it's `set LANG=zh_CN.UTF-8`;In PowerShell, it's `$env:LANG = 'zh_CN.UTF-8'`.Closes#369

1 parent6665f0e commitbb11f04Copy full SHA for bb11f04

File tree

1 file changed

-2

lines changed

utils
- getLanguage.ts

1 file changed

-2

lines changed

`‎utils/getLanguage.ts`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,10 @@ interface Language {`
`45`	`45`
`46`	`46`	`functiongetLocale(){`
`47`	`47`	`constshellLocale=`
`48`		`-Intl.DateTimeFormat().resolvedOptions().locale\|\|// Built-in ECMA-402 support`
`49`	`48`	`process.env.LC_ALL\|\|// POSIX locale environment variables`
`50`	`49`	`process.env.LC_MESSAGES\|\|`
`51`	`50`	`process.env.LANG\|\|`
`52`		`-//TODO: Windows support if needed, could consider https://www.npmjs.com/package/os-locale`
	`51`	`+Intl.DateTimeFormat().resolvedOptions().locale\|\|//Built-in ECMA-402 support`
`53`	`52`	`'en-US'// Default fallback`
`54`	`53`
`55`	`54`	`constlocale=shellLocale.split('.')[0].replace('_','-')`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitbb11f04

File tree

1 file changed

1 file changed

`‎utils/getLanguage.ts`

0 commit comments