Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/corePublic

chore(sfc-playground): import vaporInteropPlugin only if Vapor mode is supported#13645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
edison1105 merged 3 commits intomainfromedison/fix/sfc_playground
Jul 17, 2025

Conversation

edison1105
Copy link
Member

@edison1105edison1105 commentedJul 16, 2025
edited by coderabbitaibot
Loading

close#13622

Summary by CodeRabbit

  • New Features

    • The playground now dynamically detects if the current Vue version supports Vapor mode (Vue 3.6+), and adjusts the preview environment accordingly.
  • Chores

    • Updated the "@vue/repl" dependency to version ^4.6.2.

TheAlexLichter reacted with heart emoji
@coderabbitaicoderabbitai
Copy link

coderabbitaibot commentedJul 16, 2025
edited
Loading

Walkthrough

The changes update the "@vue/repl" dependency version in the SFC Playground's package.json and modify App.vue to conditionally enable thevaporInteropPlugin in the REPL preview options based on the detected Vue version. The REPL reloads when the Vue version changes, allowing dynamic support for Vapor features.

Changes

File(s)Change Summary
packages-private/sfc-playground/package.jsonUpdated "@vue/repl" dependency version from "^4.6.1" to "^4.6.2".
packages-private/sfc-playground/src/App.vueAdded logic to detect Vue version, conditionally enablevaporInteropPlugin, and reload REPL.

Sequence Diagram(s)

sequenceDiagram    participant User    participant App.vue    participant REPL    User->>App.vue: Change Vue version    App.vue->>App.vue: Parse version, set isVaporSupported    App.vue->>REPL: Reload REPL if version changed    App.vue->>REPL: Pass previewOptions (with or without vaporInteropPlugin)    REPL-->>User: Render preview with correct options
Loading

Assessment against linked issues

ObjectiveAddressedExplanation
Provide a way to enablecreateVaporApp in the Vue SFC Playground (#13622)

Possibly related PRs

Poem

In the playground where code does hop,
Now Vapor support is just a swap!
With version checks and plugins new,
The REPL reloads for every view.
A bunny cheers, with ears held high—
“Try Vapor mode, just give it a try!”
🐇✨


🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@github-actionsGitHub Actions
Copy link

Size Report

Bundles

FileSizeGzipBrotli
runtime-dom.global.prod.js101 kB38.4 kB34.5 kB
vue.global.prod.js159 kB58.5 kB52.1 kB

Usages

NameSizeGzipBrotli
createApp (CAPI only)46.5 kB18.2 kB16.7 kB
createApp54.5 kB21.2 kB19.4 kB
createSSRApp58.7 kB22.9 kB20.9 kB
defineCustomElement59.5 kB22.8 kB20.8 kB
overall68.5 kB26.4 kB24 kB

@pkg-pr-newpkg.pr.new
Copy link

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13645

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13645

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13645

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13645

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13645

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13645

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13645

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13645

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13645

vue

npm i https://pkg.pr.new/vue@13645

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13645

commit:a49cdc1

Copy link

@coderabbitaicoderabbitaibot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages-private/sfc-playground/src/App.vue (1)

119-130:Improve version parsing robustness.

The version parsing logic works correctly for the expected format, but consider adding error handling for malformed version strings.

-    const [major, minor] = (version || store.compiler.version)-      .split('.')-      .map((v: string) => parseInt(v, 10))+    const versionString = version || store.compiler.version+    const parts = versionString.split('.')+    const major = parseInt(parts[0], 10) || 0+    const minor = parseInt(parts[1], 10) || 0++    if (isNaN(major) || isNaN(minor)) {+      console.warn(`Invalid version format: ${versionString}`)+      isVaporSupported.value = false+      return+    }
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between347ef1d anda49cdc1.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages-private/sfc-playground/package.json (1 hunks)
  • packages-private/sfc-playground/src/App.vue (3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
🔇 Additional comments (4)
packages-private/sfc-playground/package.json (1)

16-16:Dependency update approved:@vue/repl@^4.6.2 is available with no known security issues.

Version 4.6.2 is published on npm, and our audit did not surface any advisories for this package. You can safely proceed with the update.

packages-private/sfc-playground/src/App.vue (3)

5-5:LGTM: Import addition is correct.

Thewatch import is properly added to support the new version watching functionality.


132-145:LGTM: Preview options logic is well-implemented.

The conditional plugin import and usage is correctly implemented:

  • Conditionally importsvaporInteropPlugin based on Vue version support
  • Properly applies the plugin to the app when supported
  • Maintains backward compatibility with existing custom formatter logic

176-176:LGTM: Template change is correct.

The change from inline options to the computedpreviewOptions property enables dynamic plugin configuration based on Vue version.

@edison1105edison1105 changed the titlefix(sfc-playground): conditionally import vaporInteropPluginchore(sfc-playground): import vaporInteropPlugin only if Vapor mode is supportedJul 16, 2025
Comment on lines 13 to 15
"vite":"catalog:"
},
"dependencies": {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good

@cabdikariim242
Copy link

Looks good

@edison1105edison1105 merged commite0e8221 intomainJul 17, 2025
16 checks passed
@edison1105edison1105 deleted the edison/fix/sfc_playground branchJuly 17, 2025 02:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

@cabdikariim242cabdikariim242cabdikariim242 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue SFC Playground has nowhere to enablecreateVaporApp
2 participants
@edison1105@cabdikariim242

[8]ページ先頭

©2009-2025 Movatter.jp