Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/corePublic

chore(types): remove global declared script setup helpers#13631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
KazariEX wants to merge1 commit intovuejs:main
base:main
Choose a base branch
Loading
fromKazariEX:fix/remove-global-macros

Conversation

KazariEX
Copy link
Member

@KazariEXKazariEX commentedJul 14, 2025
edited by coderabbitaibot
Loading

We generate imports for these helpers in the correct setup scope in language tools, so this file is no longer needed, and it also caused completion for these helpers to appear in non-setup scripts incorrectly.

Summary by CodeRabbit

  • Chores
    • Removed global TypeScript declarations for several script setup helper functions, includingdefineProps,defineEmits,defineExpose,defineOptions,defineSlots,defineModel, andwithDefaults. This may affect global type availability in some development environments.

@coderabbitaicoderabbitai
Copy link

coderabbitaibot commentedJul 14, 2025
edited
Loading

Walkthrough

A TypeScript declaration file that globally declared several script setup helper functions and their type aliases was deleted. This removal eliminates the global type definitions for helpers such asdefineProps,defineEmits,defineExpose, and others from the runtime core package.

Changes

File(s)Change Summary
packages/runtime-core/types/scriptSetupHelpers.d.tsDeleted TypeScript declaration file for global script setup helper functions and type aliases.

Poem

A file once lived, with helpers so neat,
Declaring the types for each global treat.
Now it has vanished, its duties complete,
The code hops along—no more global cheat!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between347ef1d ande329206.

📒 Files selected for processing (1)
  • packages/runtime-core/types/scriptSetupHelpers.d.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/runtime-core/types/scriptSetupHelpers.d.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@github-actionsGitHub Actions
Copy link

Size Report

Bundles

FileSizeGzipBrotli
runtime-dom.global.prod.js101 kB38.4 kB34.5 kB
vue.global.prod.js159 kB58.5 kB52.1 kB

Usages

NameSizeGzipBrotli
createApp (CAPI only)46.5 kB18.2 kB16.7 kB
createApp54.5 kB21.2 kB19.4 kB
createSSRApp58.7 kB22.9 kB20.9 kB
defineCustomElement59.5 kB22.8 kB20.8 kB
overall68.5 kB26.4 kB24 kB

@pkg-pr-newpkg.pr.new
Copy link

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13631

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13631

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13631

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13631

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13631

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13631

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13631

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13631

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13631

vue

npm i https://pkg.pr.new/vue@13631

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13631

commit:e329206

@edison1105
Copy link
Member

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
primevuesuccesssuccess
language-toolssuccesssuccess
quasarsuccesssuccess
piniasuccesssuccess
test-utilssuccesssuccess
vue-i18nsuccesssuccess
vue-macrosfailurefailure
vitepresssuccesssuccess
vite-plugin-vuesuccesssuccess
radix-vuesuccesssuccess
routersuccesssuccess
vueusesuccesssuccess
nuxtsuccesssuccess
vantsuccessfailure
vuetifysuccesssuccess
vue-simple-compilersuccesssuccess

@edison1105
Copy link
Member

@zhiyuanzmj
Copy link
Member

I can add those global macros types for vue-macros

@edison1105edison1105 changed the titlefix(runtime-core): remove global declared script setup helperschore(types): remove global declared script setup helpersJul 16, 2025
@edison1105edison1105 added scope: types ready for reviewThis PR requires more reviews labelsJul 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready for reviewThis PR requires more reviewsscope: types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@KazariEX@edison1105@vue-bot@zhiyuanzmj

[8]ページ先頭

©2009-2025 Movatter.jp