Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/corePublic

fix: handle nullish dynamic event name with event modifiers#13060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
linzhe141 wants to merge5 commits intovuejs:main
base:main
Choose a base branch
Loading
fromlinzhe141:fix-nullish-dynamic-event

Conversation

linzhe141
Copy link
Contributor

@linzhe141linzhe141 commentedMar 18, 2025•
edited by coderabbitaibot
Loading

close#13056

Summary by CodeRabbit

  • New Features

    • Improved support for dynamic event keys with event modifiers (such as .once, .passive, .capture) in templates, ensuring correct event handling for dynamically bound events.

  • Tests

    • Added new test cases to verify correct code generation for dynamic event keys with modifiers.

edison1105 and linzhe141 reacted with thumbs up emoji
@linzhe141linzhe141 marked this pull request as draftMarch 18, 2025 03:28
@github-actionsGitHub Actions
Copy link

github-actionsbot commentedMar 18, 2025•
edited
Loading

Size Report

Bundles

FileSizeGzipBrotli
runtime-dom.global.prod.js101 kB (+63 B)38.4 kB (+21 B)34.6 kB (+15 B)
vue.global.prod.js159 kB (+130 B)58.5 kB (+32 B)52.1 kB (+23 B)

Usages

NameSizeGzipBrotli
createApp (CAPI only)46.5 kB18.2 kB16.7 kB
createApp54.5 kB21.2 kB19.4 kB
createSSRApp58.7 kB22.9 kB20.9 kB
defineCustomElement59.5 kB22.8 kB20.8 kB
overall68.5 kB26.4 kB24 kB

@pkg-pr-newpkg.pr.new
Copy link

pkg-pr-newbot commentedMar 18, 2025•
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13060

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13060

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13060

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13060

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13060

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13060

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13060

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13060

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13060

vue

npm i https://pkg.pr.new/vue@13060

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13060

commit:f251c6c

@linzhe141linzhe141 changed the titlefix: handle nullish dynamic event name with a modifierfix: handle nullish dynamic event name with event modifiersMar 18, 2025
@linzhe141linzhe141 marked this pull request as ready for reviewMarch 18, 2025 06:17
@jh-leong
Copy link
Member

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
quasar✅success✅success
language-tools✅success✅success
primevue✅success✅success
pinia✅success✅success
radix-vue✅success✅success
router✅success✅success
nuxt❌failure✅success
vant✅success✅success
vite-plugin-vue✅success✅success
vuetify✅success✅success
vueuse✅success✅success
vitepress✅success✅success
vue-macros✅success✅success
vue-i18n✅success✅success
vue-simple-compiler✅success✅success
test-utils✅success✅success

@edison1105edison1105 added ready to mergeThe PR is ready to be merged. 🍰 p2-nice-to-havePriority 2: this is not breaking anything but nice to have it addressed. labelsMar 18, 2025
Copy link
Contributor

@skirtles-codeskirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think this PR needs theminor label.withDynamicEventModifiers in the compiler output won't be compatible with earlier versions of the runtime, so I don't think it can go in a patch release.

edison1105 reacted with thumbs up emoji
eventName: string,
modifierPostfix: string,
): string {
if (eventName != null && eventName !== '') return eventName + modifierPostfix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Are there any circumstances whereeventName would benull orundefined? From the test cases it seems like_toHandlerKey would have already converted those to empty strings.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for your review. Sorry I didn't notice the review right away. The eventName can only be a string. I will modify it.

@coderabbitaicoderabbitai
Copy link

coderabbitaibot commentedJun 3, 2025•
edited
Loading

Walkthrough

A new runtime helper and utility function were introduced to handle dynamic event names with modifiers in Vue's compiler and runtime. The transformation logic for dynamic event keys with modifiers was updated, and corresponding tests were added to verify correct handling, especially when the event name is nullish or empty.

Changes

File(s)Change Summary
packages/compiler-dom/tests/transforms/vOn.spec.tsAdded a test case for dynamic event keys with modifiers, verifying correct code generation.
packages/compiler-dom/src/runtimeHelpers.tsIntroducedV_ON_WITH_DYNAMIC_EVENT_MODIFIERS helper and registered it for runtime use.
packages/compiler-dom/src/transforms/vOn.tsUpdated dynamic key modifier logic to use the new helper instead of string concatenation.
packages/runtime-dom/src/directives/vOn.tsAddedwithDynamicEventModifiers utility function to handle event name and modifier postfix concatenation safely.
packages/runtime-dom/src/index.tsExportedwithDynamicEventModifiers from the directives module.

Sequence Diagram(s)

sequenceDiagram    participant Template    participant Compiler    participant RuntimeHelpers    participant Runtime    Template->>Compiler: Uses @[eventName].modifier="handler"    Compiler->>RuntimeHelpers: Calls V_ON_WITH_DYNAMIC_EVENT_MODIFIERS(eventName, modifierPostfix)    RuntimeHelpers->>Runtime: Registers withDynamicEventModifiers helper    Runtime->>Runtime: withDynamicEventModifiers(eventName, modifierPostfix)    Runtime-->>Template: Returns correct event attribute or empty string
Loading

Assessment against linked issues

ObjectiveAddressedExplanation
Prevent modifier name from becoming an attribute when dynamic event name is nullish/empty (#13056)✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Poem

In the garden of code where the events do bloom,
A rabbit hopped in with a helper and room.
No more stray modifiers when names disappear,
Just clean little petals—no attributes here!
With dynamic delight and a whisker's cheer,
Bugs hop away, and the code grows clear.
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between5bd5dbd andf251c6c.

📒 Files selected for processing (1)
  • packages/runtime-dom/src/directives/vOn.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/runtime-dom/src/directives/vOn.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

@linzhe141linzhe141force-pushed thefix-nullish-dynamic-event branch 2 times, most recently from4c8493b tod2d2e3dCompareJuly 15, 2025 14:23
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skirtles-codeskirtles-codeAwaiting requested review from skirtles-code

Assignees
No one assigned
Labels
🍰 p2-nice-to-havePriority 2: this is not breaking anything but nice to have it addressed.ready to mergeThe PR is ready to be merged.version: minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nullish dynamic event name with a modifier creates attribute with modifier's name
5 participants
@linzhe141@jh-leong@vue-bot@skirtles-code@edison1105
[8]ページ先頭
©2009-2025 Movatter.jp