Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
/corePublic

feat(types): enhanced defineComponent inference#12935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
johnsoncodehk wants to merge130 commits intovuejs:minor
base:minor
Choose a base branch
Loading
fromjohnsoncodehk:define-component-next

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehkjohnsoncodehk commentedFeb 24, 2025
edited
Loading

This PR is all about improving the implementations ofdefineComponent type inference. It's not a complete rewrite because we can't aggressively rewrite or remove existing types/interfaces to maintain backward compatibility (if we have plans for Vue 4 we can revisit that.)

Improvements / Changes

  • TS completion in component options is 40% faster
  • The "this" type in data and props options is more accurate
  • New DefineComponent2 type passes the structured component options type parameter as is, which streamlined .d.ts output on tsc emit: props types are now printed as is to .d.ts, same types are no longer serialized to multiple parameters in DefineComponent (reduce about 35% code in naive-ui .d.ts)
  • Tsc performance improved by about 8% in elk repo
  • Prop options (type, required, default, validator) can now navigate to TS definitions
  • emits: {} is now correctly handled as an empty event set
  • Simplified mixins, extends options inference (no longer using ComponentOptionsMixin intermediate type)
  • Simplify h function overloads (remove dependency on helper types such as DefineComponent, ConcreteComponent, etc.)

KazariEX, jh-leong, edison1105, zhiyuanzmj, GeoffreyParrier, jacekkarczmarczyk, franciscohermida, TheAlexLichter, Q16solver, 94726, and 11 more reacted with rocket emoji
@johnsoncodehk
Copy link
MemberAuthor

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
language-toolssuccesssuccess
primevuesuccesssuccess
piniafailuresuccess
test-utilssuccesssuccess
nuxtsuccesssuccess
vite-plugin-vuesuccesssuccess
quasarsuccesssuccess
vue-simple-compilersuccesssuccess
vantsuccesssuccess
vueusesuccesssuccess
vitepresssuccesssuccess
vue-i18nsuccesssuccess
vuetifyfailuresuccess
routersuccesssuccess
radix-vuesuccesssuccess
vue-macrossuccesssuccess

@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
piniafailuresuccess
routersuccesssuccess
vuetifyfailuresuccess
primevuesuccesssuccess
radix-vuesuccesssuccess
vantsuccesssuccess
vite-plugin-vuesuccesssuccess
language-toolsfailuresuccess
vue-i18nsuccesssuccess
vitepresssuccesssuccess
vueusesuccesssuccess
nuxtsuccesssuccess
vue-simple-compilersuccesssuccess
quasarsuccesssuccess
vue-macrossuccesssuccess
test-utilssuccesssuccess

@johnsoncodehk
Copy link
MemberAuthor

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
nuxtsuccesssuccess
language-toolssuccesssuccess
quasarsuccesssuccess
primevuesuccesssuccess
piniasuccesssuccess
routersuccesssuccess
vitepresssuccesssuccess
radix-vuesuccesssuccess
vuetifyfailuresuccess
vue-i18nsuccesssuccess
test-utilssuccesssuccess
vueusesuccesssuccess
vite-plugin-vuesuccesssuccess
vue-simple-compilersuccesssuccess
vantsuccesssuccess
vue-macrossuccesssuccess

@johnsoncodehk
Copy link
MemberAuthor

/ecosystem-ci run

github-actions[bot] reacted with thumbs up emoji

@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vuejsvuejs deleted a comment fromjohnsoncodehkMar 31, 2025
@vue-bot
Copy link
Contributor

📝 Ran ecosystem CI:Open

suiteresultlatest scheduled
piniasuccesssuccess
routersuccesssuccess
primevuesuccesssuccess
nuxtsuccesssuccess
quasarsuccesssuccess
language-toolssuccesssuccess
vite-plugin-vuesuccesssuccess
vue-simple-compilersuccesssuccess
vitepresssuccesssuccess
test-utilssuccesssuccess
vue-i18nsuccesssuccess
vueusesuccesssuccess
vue-macrossuccesssuccess
vantsuccesssuccess
vuetifysuccesssuccess
radix-vuesuccesssuccess

@coderabbitaicoderabbitai
Copy link

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat withCodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag@coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag@coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on oursupport page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings togenerate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add@coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add@coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add@coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a.coderabbit.yaml file to the root of your repository.
  • Please see theconfiguration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit ourDocumentation for detailed information on how to use CodeRabbit.
  • Join ourDiscord Community to get help, request features, and share feedback.
  • Follow us onX/Twitter for updates and announcements.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jacekkarczmarczykjacekkarczmarczykjacekkarczmarczyk left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@johnsoncodehk@vue-bot@jacekkarczmarczyk@yyx990803@KazariEX

[8]ページ先頭

©2009-2025 Movatter.jp