Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings
/corePublic

fix(compiler-vapor): camelize kebab-case component event handlers#14211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
edison1105 merged 1 commit intominorfromedison/fix/kebabCaseEventName
Dec 17, 2025

Conversation

@edison1105
Copy link
Member

No description provided.

CopilotAI review requested due to automatic review settingsDecember 17, 2025 01:51
@coderabbitai
Copy link

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the.coderabbit.yaml file in this repository. To trigger a single review, invoke the@coderabbitai review command.

You can disable this status message by setting thereviews.review_status tofalse in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branchedison/fix/kebabCaseEventName

Comment@coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

Size Report

Bundles

FileSizeGzipBrotli
compiler-dom.global.prod.js85.2 kB29.9 kB26.4 kB
runtime-dom.global.prod.js108 kB40.6 kB36.5 kB
vue.global.prod.js166 kB60.5 kB53.9 kB

Usages

NameSizeGzipBrotli
createApp (CAPI only)48.2 kB18.9 kB17.3 kB
createApp57.2 kB22 kB20.1 kB
createApp + vaporInteropPlugin96.3 kB35.6 kB32 kB
createVaporApp42.3 kB15.6 kB14.2 kB
createSSRApp61.6 kB23.8 kB21.7 kB
defineCustomElement63.3 kB23.9 kB21.8 kB
overall71.9 kB27.2 kB24.8 kB

@pkg-pr-new
Copy link

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14211
npm i https://pkg.pr.new/@vue/compiler-core@14211
yarn add https://pkg.pr.new/@vue/compiler-core@14211.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14211
npm i https://pkg.pr.new/@vue/compiler-dom@14211
yarn add https://pkg.pr.new/@vue/compiler-dom@14211.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14211
npm i https://pkg.pr.new/@vue/compiler-sfc@14211
yarn add https://pkg.pr.new/@vue/compiler-sfc@14211.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14211
npm i https://pkg.pr.new/@vue/compiler-ssr@14211
yarn add https://pkg.pr.new/@vue/compiler-ssr@14211.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14211
npm i https://pkg.pr.new/@vue/compiler-vapor@14211
yarn add https://pkg.pr.new/@vue/compiler-vapor@14211.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14211
npm i https://pkg.pr.new/@vue/reactivity@14211
yarn add https://pkg.pr.new/@vue/reactivity@14211.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14211
npm i https://pkg.pr.new/@vue/runtime-core@14211
yarn add https://pkg.pr.new/@vue/runtime-core@14211.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14211
npm i https://pkg.pr.new/@vue/runtime-dom@14211
yarn add https://pkg.pr.new/@vue/runtime-dom@14211.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14211
npm i https://pkg.pr.new/@vue/runtime-vapor@14211
yarn add https://pkg.pr.new/@vue/runtime-vapor@14211.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14211
npm i https://pkg.pr.new/@vue/server-renderer@14211
yarn add https://pkg.pr.new/@vue/server-renderer@14211.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14211
npm i https://pkg.pr.new/@vue/shared@14211
yarn add https://pkg.pr.new/@vue/shared@14211.tgz

vue

pnpm add https://pkg.pr.new/vue@14211
npm i https://pkg.pr.new/vue@14211
yarn add https://pkg.pr.new/vue@14211.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14211
npm i https://pkg.pr.new/@vue/compat@14211
yarn add https://pkg.pr.new/@vue/compat@14211.tgz

commit:235705d

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR fixes the Vapor compiler to properly camelize kebab-case component event handlers, aligning its behavior with the standard Vue compiler. Previously, kebab-case event names like@update-model were incorrectly kept as"onUpdate-model" instead of being converted toonUpdateModel.

Key Changes:

  • Applycamelize transformation to static event handler keys before converting them to handler format
  • Update existing test expectations to reflect the corrected behavior
  • Add new test case specifically for kebab-case event handler camelization

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

FileDescription
packages/compiler-vapor/src/generators/prop.tsImportscamelize and applies it to static handler keys beforetoHandlerKey conversion
packages/compiler-vapor/tests/transforms/vOn.spec.tsUpdates test expectation for@update-model to generate camelizedonUpdateModel and adds new test for kebab-case camelization
packages/compiler-vapor/tests/transforms/snapshots/vOn.spec.ts.snapUpdates snapshots to reflect corrected camelized output for kebab-case handlers

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@edison1105edison1105 merged commitb205408 intominorDec 17, 2025
23 checks passed
@edison1105edison1105 deleted the edison/fix/kebabCaseEventName branchDecember 17, 2025 01:58
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@edison1105
[8]ページ先頭
©2009-2025 Movatter.jp